Tests for invalid configs

Author: jml

pkg/ruler/api_test.go

@@ -150,6 +150,32 @@ func Test_PostConfig_CreatesConfig(t *testing.T) {
 	assert.Equal(t, config, result.Config)
 }
 
+// Posting an invalid config when there's none set returns an error and leaves the config unset.
+func Test_PostConfig_InvalidNewConfig(t *testing.T) {
+	setup(t)
+	defer cleanup(t)
+
+	userID := makeUserID()
+	invalidConfig := map[string]string{
+		"some.rules": "invalid config",
+	}
+	updateRequest := configUpdateRequest{
+		OldConfig: nil,
+		NewConfig: invalidConfig,
+	}
+	b, err := json.Marshal(updateRequest)
+	require.NoError(t, err)
+	reader := bytes.NewReader(b)
+	{
+		w := requestAsUser(t, userID, "POST", endpoint, reader)
+		require.Equal(t, http.StatusBadRequest, w.Code)
+	}
+	{
+		w := requestAsUser(t, userID, "GET", endpoint, nil)
+		require.Equal(t, http.StatusNotFound, w.Code)
+	}
+}
+
 // Posting to a configuration sets it so that you can get it again.
 func Test_PostConfig_UpdatesConfig(t *testing.T) {
 	setup(t)
@@ -164,6 +190,32 @@ func Test_PostConfig_UpdatesConfig(t *testing.T) {
 	assert.Equal(t, config2, view2.Config)
 }
 
+// Posting an invalid config when there's one already set returns an error and leaves the config as is.
+func Test_PostConfig_InvalidChangedConfig(t *testing.T) {
+	setup(t)
+	defer cleanup(t)
+
+	userID := makeUserID()
+	config := makeRulerConfig()
+	post(t, userID, nil, config)
+	invalidConfig := map[string]string{
+		"some.rules": "invalid config",
+	}
+	updateRequest := configUpdateRequest{
+		OldConfig: nil,
+		NewConfig: invalidConfig,
+	}
+	b, err := json.Marshal(updateRequest)
+	require.NoError(t, err)
+	reader := bytes.NewReader(b)
+	{
+		w := requestAsUser(t, userID, "POST", endpoint, reader)
+		require.Equal(t, http.StatusBadRequest, w.Code)
+	}
+	result := get(t, userID)
+	assert.Equal(t, config, result.Config)
+}
+
 // Different users can have different configurations.
 func Test_PostConfig_MultipleUsers(t *testing.T) {
 	setup(t)
@@ -241,6 +293,5 @@ func Test_GetConfigs_IncludesNewerConfigsAndExcludesOlder(t *testing.T) {
 }
 
 // Test user w/ only alertmanager config doesn't show up in getallconfigs
-// Test posting invalid config
 // Test setting ruler config doesn't change alertmanager config
 // Test setting alertmanager config doesn't change ruler config