Skip to content

Commit 4104dc6

Browse files
committed
Improved TestRing_ShuffleShardWithLookback
Signed-off-by: Marco Pracucci <[email protected]>
1 parent f5211d0 commit 4104dc6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/ring/ring_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,9 @@ func TestRing_ShuffleShardWithLookback(t *testing.T) {
905905
{what: test, shardSize: 3, expected: []string{"instance-1", "instance-2", "instance-3"}},
906906
// Scale up.
907907
{what: add, instanceID: "instance-7", instanceDesc: generateRingInstanceWithInfo("instance-7", "zone-a", []uint32{userToken(userID, "zone-a", 0) + 1}, now)},
908+
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-2", "instance-3" /* lookback: */, "instance-1"}},
908909
{what: add, instanceID: "instance-8", instanceDesc: generateRingInstanceWithInfo("instance-8", "zone-b", []uint32{userToken(userID, "zone-b", 1) + 1}, now)},
910+
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-8", "instance-3" /* lookback: */, "instance-1", "instance-2"}},
909911
{what: add, instanceID: "instance-9", instanceDesc: generateRingInstanceWithInfo("instance-9", "zone-c", []uint32{userToken(userID, "zone-c", 2) + 1}, now)},
910912
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-8", "instance-9" /* lookback: */, "instance-1", "instance-2", "instance-3"}},
911913
},
@@ -924,7 +926,9 @@ func TestRing_ShuffleShardWithLookback(t *testing.T) {
924926
{what: test, shardSize: 3, expected: []string{"instance-1", "instance-2", "instance-3"}},
925927
// Scale down.
926928
{what: remove, instanceID: "instance-1"},
929+
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-2", "instance-3"}},
927930
{what: remove, instanceID: "instance-2"},
931+
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-8", "instance-3"}},
928932
{what: remove, instanceID: "instance-3"},
929933
{what: test, shardSize: 3, expected: []string{"instance-7", "instance-8", "instance-9"}},
930934
},

0 commit comments

Comments
 (0)