Skip to content

Commit 571dec9

Browse files
tomwilkiejml
authored andcommitted
Update bigtable latency histogram buckets to reflect reality. (#588)
* Update bigtable latency histogram buckets to reflect reality. * Update comment to correct number of buckets 8 -> 6
1 parent 36f14cb commit 571dec9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/chunk/gcp/instrumentation.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ var bigtableRequestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpt
2020
Name: "bigtable_request_duration_seconds",
2121
Help: "Time spent doing Bigtable requests.",
2222

23-
// Bigtable latency seems to range from a few ms to a few sec and is
24-
// important. So use 8 buckets from 128us to 2s.
25-
Buckets: prometheus.ExponentialBuckets(0.000128, 4, 8),
23+
// Bigtable latency seems to range from a few ms to a few hundred ms and is
24+
// important. So use 6 buckets from 1ms to 1s.
25+
Buckets: prometheus.ExponentialBuckets(0.001, 4, 6),
2626
}, []string{"operation", "status_code"})
2727

2828
func init() {

0 commit comments

Comments
 (0)