Skip to content

Commit 5a86699

Browse files
committed
Review feedback, fix distributor concurrency handling
1 parent 7df5270 commit 5a86699

File tree

4 files changed

+3
-1
lines changed

4 files changed

+3
-1
lines changed

cmd/distributor/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ func main() {
4848
if err != nil {
4949
log.Fatalf("Error initializing distributor: %v", err)
5050
}
51-
go dist.Run()
5251
defer dist.Stop()
5352

5453
server := server.New(serverConfig, r)

cmd/querier/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ func main() {
4242
if err != nil {
4343
log.Fatalf("Error initializing distributor: %v", err)
4444
}
45+
defer dist.Stop()
4546

4647
server := server.New(serverConfig, r)
4748
defer server.Stop()

cmd/ruler/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ func main() {
3636
if err != nil {
3737
log.Fatalf("Error initializing distributor: %v", err)
3838
}
39+
defer dist.Stop()
3940

4041
rulerServer, err := ruler.NewServer(rulerConfig, ruler.NewRuler(rulerConfig, dist, chunkStore))
4142
if err != nil {

distributor/distributor.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ func New(cfg Config, ring ReadRing) (*Distributor, error) {
141141
}, []string{"ingester"}),
142142
}
143143
prometheus.MustRegister(d)
144+
go d.Run()
144145
return d, nil
145146
}
146147

0 commit comments

Comments
 (0)