Set timeout for ingester Push() calls

bboreham · bboreham · commit 7da18ae142aa · 2018-01-27T23:56:29.000Z
diff --git a/pkg/distributor/distributor.go b/pkg/distributor/distributor.go
@@ -347,6 +347,8 @@ func (d *Distributor) Push(ctx context.Context, req *client.WriteRequest) (*clie
 		done:           make(chan struct{}),
 		err:            make(chan error),
 	}
+	ctx, cancel := context.WithTimeout(ctx, d.cfg.RemoteTimeout)
+	defer cancel() // cancel the timeout to release resources
 	for ingester, samples := range samplesByIngester {
 		go func(ingester *ring.IngesterDesc, samples []*sampleTracker) {
 			d.sendSamples(ctx, ingester, samples, &pushTracker)

Original file line number	Diff line number	Diff line change
`@@ -347,6 +347,8 @@ func (d Distributor) Push(ctx context.Context, req client.WriteRequest) (*clie`
`347`	`347`	`done: make(chan struct{}),`
`348`	`348`	`err: make(chan error),`
`349`	`349`	`}`
	`350`	`+ ctx, cancel := context.WithTimeout(ctx, d.cfg.RemoteTimeout)`
	`351`	`+ defer cancel() // cancel the timeout to release resources`
`350`	`352`	`for ingester, samples := range samplesByIngester {`
`351`	`353`	`go func(ingester ring.IngesterDesc, samples []sampleTracker) {`
`352`	`354`	`d.sendSamples(ctx, ingester, samples, &pushTracker)`