Skip to content

Commit 871ab87

Browse files
committed
Update promql.NewEngine and v1.NewAPI
1 parent f9b2909 commit 871ab87

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

cmd/lite/main.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"flag"
55
"net/http"
66
"os"
7+
"time"
78

89
"github.com/go-kit/kit/log/level"
910
"github.com/opentracing-contrib/go-stdlib/nethttp"
@@ -147,13 +148,16 @@ func main() {
147148
sampleQueryable := querier.NewQueryable(dist, chunkStore, false)
148149
metadataQueryable := querier.NewQueryable(dist, chunkStore, true)
149150

150-
engine := promql.NewEngine(sampleQueryable, nil)
151+
maxConcurrent := 20
152+
timeout := 2 * time.Minute
153+
engine := promql.NewEngine(util.Logger, nil, maxConcurrent, timeout)
151154
api := v1.NewAPI(
152155
engine,
153156
metadataQueryable,
154157
querier.DummyTargetRetriever{},
155158
querier.DummyAlertmanagerRetriever{},
156159
func() config.Config { return config.Config{} },
160+
map[string]string{}, // TODO: include configuration flags
157161
func(f http.HandlerFunc) http.HandlerFunc { return f },
158162
func() *tsdb.DB { return nil }, // Only needed for admin APIs.
159163
false, // Disable admin APIs.

cmd/querier/main.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"flag"
55
"net/http"
66
"os"
7+
"time"
78

89
"google.golang.org/grpc"
910

@@ -91,13 +92,16 @@ func main() {
9192
sampleQueryable := querier.NewQueryable(dist, chunkStore, false)
9293
metadataQueryable := querier.NewQueryable(dist, chunkStore, true)
9394

94-
engine := promql.NewEngine(sampleQueryable, nil)
95+
maxConcurrent := 20
96+
timeout := 2 * time.Minute
97+
engine := promql.NewEngine(util.Logger, nil, maxConcurrent, timeout)
9598
api := v1.NewAPI(
9699
engine,
97100
metadataQueryable,
98101
querier.DummyTargetRetriever{},
99102
querier.DummyAlertmanagerRetriever{},
100103
func() config.Config { return config.Config{} },
104+
map[string]string{}, // TODO: include configuration flags
101105
func(f http.HandlerFunc) http.HandlerFunc { return f },
102106
func() *tsdb.DB { return nil }, // Only needed for admin APIs.
103107
false, // Disable admin APIs.

pkg/querier/dummy.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,14 @@ type DummyTargetRetriever struct{}
1212
// Targets implements TargetRetriever.
1313
func (r DummyTargetRetriever) Targets() []*scrape.Target { return nil }
1414

15+
// DroppedTargets implements TargetRetriever.
16+
func (r DummyTargetRetriever) DroppedTargets() []*scrape.Target { return nil }
17+
1518
// DummyAlertmanagerRetriever implements AlertmanagerRetriever.
1619
type DummyAlertmanagerRetriever struct{}
1720

1821
// Alertmanagers implements AlertmanagerRetriever.
1922
func (r DummyAlertmanagerRetriever) Alertmanagers() []*url.URL { return nil }
23+
24+
// DroppedAlertmanagers implements AlertmanagerRetriever.
25+
func (r DummyAlertmanagerRetriever) DroppedAlertmanagers() []*url.URL { return nil }

0 commit comments

Comments
 (0)