Skip to content

Commit bd8002e

Browse files
authored
Squashed 'tools/' changes from b783528b..35679ee5 (#521)
35679ee5 Merge pull request #110 from weaveworks/parallel-push-errors 3ae41b6f Remove unneeded if block 51ff31a5 Exit on first error 0faad9f7 Check for errors when pushing images in parallel 74dc626b Merge pull request #108 from weaveworks/disable-apt-daily b4f1d918 Merge pull request #107 from weaveworks/docker-17-update 7436aa14 Override apt daily job to not run immediately on boot 7980f152 Merge pull request #106 from weaveworks/document-docker-install-role f741e533 Bump to Docker 17.06 from CE repo 61796a1b Update Docker CE Debian repo details 0d86f5e1 Allow for Docker package to be named docker-ce 065c68d4 Document selection of Docker installation role. 38090539 Just --porcelain; it defaults to v1 11400eaa Merge pull request #105 from weaveworks/remove-weaveplugin-remnants b8b4d64c remove weaveplugin remnants 35099c93 Merge pull request #104 from weaveworks/pull-docker-py cdd48fc3 Pull docker-py to speed tests/builds up. e1c6c24b Merge pull request #103 from weaveworks/test-build-tags d5d71e06 Add -tags option so callers can pass in build tags 8949b2b5 Merge pull request #98 from weaveworks/git-status-tag ac30687f Merge pull request #100 from weaveworks/python_linting 4b125b55 Pin yapf & flake8 versions 7efb4853 Lint python linting function 444755b7 Swap diff direction to reflect changes required c5b24346 Install flake8 & yapf 5600eac5 Lint python in build-tools repo 0b02ca93 Add python linting c011c0dc Merge pull request #79 from kinvolk/schu/python-shebang 6577d078 Merge pull request #99 from weaveworks/shfmt-version 00ce0dcd Use git status instead of diff to add 'WIP' tag 411fd13a Use shfmt v1.3.0 instead of latest from master. 0d6d4da9 Run shfmt 1.3 on the code. 5cdba320 Add sudo c322ca83 circle.yml: Install shfmt binary. e59c2251 Install shfmt 1.3 binary. 30706e6b Install pyhcl in the build container. 960d2228 Merge pull request #97 from kinvolk/alban/update-shfmt-3 1d535c7b shellcheck: fix escaping issue 55424986 Merge pull request #96 from kinvolk/alban/update-shfmt-2 32f7cc51 shfmt: fix coding style 09f72af0 lint: print the diff in case of error 571c7d71 Merge pull request #95 from kinvolk/alban/update-shfmt bead6edd Update for latest shfmt b08dc4d6 Update for latest shfmt (#94) 2ed8aaa8 Add no-race argument to test script (#92) 80dd78e6 Merge pull request #91 from weaveworks/upgrade-go-1.8.1 08dcd0df Please ./lint as shfmt changed its rules between 1.0.0 and 1.3.0. a8bc9ab0 Upgrade default Go version to 1.8.1. 41c56221 Merge pull request #90 from weaveworks/build-golang-service-conf e8ebdd5e broaden imagetag regex to fix haskell build image ba3fbfa6 Merge pull request #89 from weaveworks/build-golang-service-conf e506f1b9 Fix up test script for updated shfmt 9216db86 Add stuff for service-conf build to build-goland image 66a9a93c Merge pull request #88 from weaveworks/haskell-image cb3e3a25 shfmt 74a5239e Haskell build image 4ccd42b9 Trying circle quay login b2c295fc Merge branch 'common-build' 0ac746fa Trim quay prefix in circle script c405b311 Merge pull request #87 from weaveworks/common-build 9672d7cb Push build images to quay as they have sane robot accounts a2bf1123 Review feedback fef9b7dd Add protobuf tools 10a77ead Update readme 254f2660 Don't need the image name in ffb59fcb Adding a weaveworks/build-golang image with tags b8173683 Update min Weave Net docker version cf87ca33 Merge pull request #86 from weaveworks/lock-kubeadm-version 3ae69196 Add example of custom SSH private key to tf_ssh's usage. cf8bd8af Add example of custom SSH private key to tf_ansi's usage. c7d33700 Lock kubeadm's Kubernetes version. faaaa6f2 Merge pull request #84 from weaveworks/centos-rhel ef552e7d Select weave-kube YAML URL based on K8S version. b4c11982 Upgrade default kubernetes_version to 1.6.1. b82805ef Use a fixed version of kubeadm. f33888bc Factorise and make kubeconfig option optional. f7b8b897 Install EPEL repo for CentOS. 615917a6 Fix error in decrypting AWS access key and secret. 86f97b42 Add CentOS 7 AMI and username for AWS via Terraform. eafd810e Add tf_ansi example with Ansible variables. 2b05787f Skip setup of Docker over TCP for CentOS/RHEL. 84c420b6 Add docker-ce role for CentOS/RHEL. 00a820cd Add setup_weave-net_debug.yml playbook for user issues' debugging. 3eae480b Upgrade default kubernetes_version to 1.5.4. 753921cf Allow injection of Docker installation role. e1ff90d2 Fix kubectl taint command for 1.5. b989e97a Fix typo in kubectl taint for single node K8S cluster. 541f58d2 Remove 'install_recommends: no' for ethtool. c3f97115 Make Ansible role docker-from-get.docker.com work on RHEL/CentOS. 038c0ae8 Add frequently used OS images, for convenience. d30649f0 Add --insecure-registry to docker.conf 1dd92188 shfmt -i 4 -w push-images 6de96ac7 Add option to not push docker hub images 310f53dc Add push-images script from cortex 8641381b Add port 6443 to kubeadm join commands for K8S 1.6+. 50bf0bc6 Force type of K8S token to string. 08ab1c0c Remove trailing whitespaces. ae9efb83 Enable testing against K8S release candidates. 9e32194c Secure GCP servers for Scope: open port 80. a22536ac Secure GCP servers for Scope. 89c3a29b Merge pull request #78 from weaveworks/lint-merge-rebase-issue-in-docs 73ad56d7 Add linter function to avoid bad merge/rebase artefact 31d069d6 Change Python shebang to `#!/usr/bin/env python` 52d695cc Merge pull request #77 from kinvolk/schu/fix-relative-weave-path 77aed016 Merge pull request #73 from weaveworks/mike/sched/fix-unicode-issue 7c080f45 integration/sanity_check: disable SC1090 d6d360a1 integration/gce.sh: update gcloud command e8def2c4 provisioning/setup: fix shellcheck SC2140 cc022241 integration/config: fix weave path 9c0d6a55 Fix config_management/README.md 334708ca Merge pull request #75 from kinvolk/alban/external-build-1 da2505d6 gce.sh: template: print creation date e6768547 integration tests: fix user account 85308369 host nameing: add repo name b556c0ad gce.sh: fix deletion of gce instances 2ecd1c2c integration: fix GCE --zones/--zone parameter 3e863df9 sched: Fix unicode encoding issues 51785b5f Use rm -f and set current dir using BASH_SOURCE. f5c6d68c Merge pull request #71 from kinvolk/schu/fix-linter-warnings 0269628e Document requirement for `lint_sh` 9a3f09e6 Fix linter warnings efcf9d21 Merge pull request #53 from weaveworks/2647-testing-mvp d31ea574 Weave Kube playbook now works with multiple nodes. 27868dd5 Add GCP firewall rule for FastDP crypto. edc8bb3a Differentiated name of dev and test playbooks, to avoid confusion. efa3df7c Moved utility Ansible Yaml to library directory. fcd2769e Add shorthands to run Ansible playbooks against Terraform-provisioned virtual machines. f7946fbb Add shorthands to SSH into Terraform-provisioned virtual machines. aad5c6f1 Mention Terraform and Ansible in README.md. dddabf0e Add Terraform output required for templates' creation. dcc7d025 Add Ansible configuration playbooks for development environments. f86481ca Add Ansible configuration playbooks for Docker, K8S and Weave-Net. efedd258 Git-ignore Ansible retry files. 765c4ca1 Add helper functions to setup Terraform programmatically. 801dd1d1 Add Terraform cloud provisioning scripts. b8017e19 Install hclfmt on CircleCI. 4815e19b Git-ignore Terraform state files. 0aaebc7d Add script to generate cartesian product of dependencies of cross-version testing. 007d90ab Add script to list OS images from GCP, AWS and DO. ca65cc02 Add script to list relevant versions of Go, Docker and Kubernetes. aa66f447 Scripts now source dependencies using absolute path (previously breaking make depending on current directory). 7865e86d Add -p option to parallelise lint. 36c1835b Merge pull request #69 from weaveworks/mflag 98575686 Use mflag and mflagext package from weaveworks/common. 97991128 Quote bash variable. 10a36b33 Merge pull request #67 from weaveworks/shfmt-ignore a59884f3 Add support for .lintignore. 03cc5989 Don't lint generated protobuf code. 2b55c2df Merge pull request #66 from weaveworks/reduce-test-timeout d4e163cc Make timeout a flag 49a86091 Reduce test timeout 8fa15cba Merge pull request #63 from weaveworks/test-defaults git-subtree-dir: tools git-subtree-split: 35679ee5ff17c4edf864b7c43dc70a40337fcd80
1 parent 50cd8a9 commit bd8002e

File tree

74 files changed

+3556
-159
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+3556
-159
lines changed

tools/.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,7 @@ socks/image.tar
44
runner/runner
55
*.pyc
66
*~
7+
terraform.tfstate
8+
terraform.tfstate.backup
9+
*.retry
10+
build/**/.uptodate

tools/README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,17 @@
22

33
Included in this repo are tools shared by weave.git and scope.git. They include
44

5+
- ```build```: a set of docker base-images for building weave
6+
projects. These should be used instead of giving each project its
7+
own build image.
8+
- ```provisioning```: a set of Terraform scripts to provision virtual machines in GCP, AWS or Digital Ocean.
9+
- ```config_management```: a set of Ansible playbooks to configure virtual machines for development, testing, etc.
510
- ```cover```: a tool which merges overlapping coverage reports generated by go
611
test
712
- ```files-with-type```: a tool to search directories for files of a given
813
MIME type
9-
- ```lint```: a script to lint Go project; runs various tools like golint, go
10-
vet, errcheck etc
14+
- ```lint```: a script to lint go, sh and hcl files; runs various tools like
15+
golint, go vet, errcheck, shellcheck etc
1116
- ```rebuild-image```: a script to rebuild docker images when their input files
1217
change; useful when you using docker images to build your software, but you
1318
don't want to build the image every time.
@@ -24,6 +29,11 @@ Included in this repo are tools shared by weave.git and scope.git. They include
2429
- ```scheduler```: an appengine application that can be used to distribute
2530
tests across different shards in CircleCI.
2631

32+
## Requirements
33+
34+
- ```lint``` requires shfmt to lint sh files; get shfmt with
35+
```go get -u gopkg.in/mvdan/sh.v1/cmd/shfmt```
36+
2737
## Using build-tools.git
2838

2939
To allow you to tie your code to a specific version of build-tools.git, such

tools/build/Makefile

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
.PHONY: all clean images
2+
.DEFAULT_GOAL := all
3+
4+
# Boiler plate for bulding Docker containers.
5+
# All this must go at top of file I'm afraid.
6+
IMAGE_PREFIX := quay.io/weaveworks/build-
7+
IMAGE_TAG := $(shell ../image-tag)
8+
UPTODATE := .uptodate
9+
10+
# Every directory with a Dockerfile in it builds an image called
11+
# $(IMAGE_PREFIX)<dirname>. Dependencies (i.e. things that go in the image)
12+
# still need to be explicitly declared.
13+
%/$(UPTODATE): %/Dockerfile %/*
14+
$(SUDO) docker build -t $(IMAGE_PREFIX)$(shell basename $(@D)) $(@D)/
15+
$(SUDO) docker tag $(IMAGE_PREFIX)$(shell basename $(@D)) $(IMAGE_PREFIX)$(shell basename $(@D)):$(IMAGE_TAG)
16+
touch $@
17+
18+
# Get a list of directories containing Dockerfiles
19+
DOCKERFILES := $(shell find . -name tools -prune -o -name vendor -prune -o -type f -name 'Dockerfile' -print)
20+
UPTODATE_FILES := $(patsubst %/Dockerfile,%/$(UPTODATE),$(DOCKERFILES))
21+
DOCKER_IMAGE_DIRS := $(patsubst %/Dockerfile,%,$(DOCKERFILES))
22+
IMAGE_NAMES := $(foreach dir,$(DOCKER_IMAGE_DIRS),$(patsubst %,$(IMAGE_PREFIX)%,$(shell basename $(dir))))
23+
images:
24+
$(info $(IMAGE_NAMES))
25+
@echo > /dev/null
26+
27+
# Define imagetag-golang, etc, for each image, which parses the dockerfile and
28+
# prints an image tag. For example:
29+
# FROM golang:1.8.1-stretch
30+
# in the "foo/Dockerfile" becomes:
31+
# $ make imagetag-foo
32+
# 1.8.1-stretch
33+
define imagetag_dep
34+
.PHONY: imagetag-$(1)
35+
$(patsubst $(IMAGE_PREFIX)%,imagetag-%,$(1)): $(patsubst $(IMAGE_PREFIX)%,%,$(1))/Dockerfile
36+
@cat $$< | grep "^FROM " | head -n1 | sed 's/FROM \(.*\):\(.*\)/\2/'
37+
endef
38+
$(foreach image, $(IMAGE_NAMES), $(eval $(call imagetag_dep, $(image))))
39+
40+
all: $(UPTODATE_FILES)
41+
42+
clean:
43+
$(SUDO) docker rmi $(IMAGE_NAMES) >/dev/null 2>&1 || true
44+
rm -rf $(UPTODATE_FILES)
45+
46+

tools/build/golang/Dockerfile

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
FROM golang:1.8.0-stretch
2+
RUN apt-get update && \
3+
apt-get install -y \
4+
curl \
5+
file \
6+
git \
7+
jq \
8+
libprotobuf-dev \
9+
make \
10+
protobuf-compiler \
11+
python-pip \
12+
python-requests \
13+
python-yaml \
14+
unzip && \
15+
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
16+
RUN pip install attrs pyhcl
17+
RUN curl -fsSLo shfmt https://github.com/mvdan/sh/releases/download/v1.3.0/shfmt_v1.3.0_linux_amd64 && \
18+
echo "b1925c2c405458811f0c227266402cf1868b4de529f114722c2e3a5af4ac7bb2 shfmt" | sha256sum -c && \
19+
chmod +x shfmt && \
20+
mv shfmt /usr/bin
21+
RUN go clean -i net && \
22+
go install -tags netgo std && \
23+
go install -race -tags netgo std
24+
RUN go get -tags netgo \
25+
github.com/FiloSottile/gvt \
26+
github.com/client9/misspell/cmd/misspell \
27+
github.com/fatih/hclfmt \
28+
github.com/fzipp/gocyclo \
29+
github.com/gogo/protobuf/gogoproto \
30+
github.com/gogo/protobuf/protoc-gen-gogoslick \
31+
github.com/golang/dep/... \
32+
github.com/golang/lint/golint \
33+
github.com/golang/protobuf/protoc-gen-go \
34+
github.com/kisielk/errcheck \
35+
github.com/mjibson/esc \
36+
github.com/prometheus/prometheus/cmd/promtool && \
37+
rm -rf /go/pkg /go/src
38+
RUN mkdir protoc && \
39+
cd protoc && \
40+
curl -O -L https://github.com/google/protobuf/releases/download/v3.1.0/protoc-3.1.0-linux-x86_64.zip && \
41+
unzip protoc-3.1.0-linux-x86_64.zip && \
42+
cp bin/protoc /usr/bin/ && \
43+
chmod o+x /usr/bin/protoc && \
44+
cd .. && \
45+
rm -rf protoc
46+
RUN mkdir -p /var/run/secrets/kubernetes.io/serviceaccount && \
47+
touch /var/run/secrets/kubernetes.io/serviceaccount/token
48+
COPY build.sh /
49+
ENTRYPOINT ["/build.sh"]

tools/build/golang/build.sh

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#!/bin/sh
2+
3+
set -eu
4+
5+
if [ -n "${SRC_NAME:-}" ]; then
6+
SRC_PATH=${SRC_PATH:-$GOPATH/src/$SRC_NAME}
7+
elif [ -z "${SRC_PATH:-}" ]; then
8+
echo "Must set either \$SRC_NAME or \$SRC_PATH."
9+
exit 1
10+
fi
11+
12+
# If we run make directly, any files created on the bind mount
13+
# will have awkward ownership. So we switch to a user with the
14+
# same user and group IDs as source directory. We have to set a
15+
# few things up so that sudo works without complaining later on.
16+
uid=$(stat --format="%u" "$SRC_PATH")
17+
gid=$(stat --format="%g" "$SRC_PATH")
18+
echo "weave:x:$uid:$gid::$SRC_PATH:/bin/sh" >>/etc/passwd
19+
echo "weave:*:::::::" >>/etc/shadow
20+
echo "weave ALL=(ALL) NOPASSWD: ALL" >>/etc/sudoers
21+
22+
su weave -c "PATH=$PATH make -C $SRC_PATH BUILD_IN_CONTAINER=false $*"

tools/build/haskell/Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
FROM fpco/stack-build:lts-8.9
2+
COPY build.sh /
3+
COPY copy-libraries /usr/local/bin/
4+
ENTRYPOINT ["/build.sh"]

tools/build/haskell/build.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/sh
2+
#
3+
# Build a static Haskell binary using stack.
4+
5+
set -eu
6+
7+
if [ -z "${SRC_PATH:-}" ]; then
8+
echo "Must set \$SRC_PATH."
9+
exit 1
10+
fi
11+
12+
make -C "$SRC_PATH" BUILD_IN_CONTAINER=false "$@"

tools/build/haskell/copy-libraries

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
#!/bin/bash
2+
#
3+
# Copy dynamically linked libraries for a binary, so we can assemble a Docker
4+
# image.
5+
#
6+
# Run with:
7+
# copy-libraries /path/to/binary /output/dir
8+
#
9+
# Dependencies:
10+
# - awk
11+
# - cp
12+
# - grep
13+
# - ldd
14+
# - mkdir
15+
16+
set -o errexit
17+
set -o nounset
18+
set -o pipefail
19+
20+
# Path to a Linux binary that we're going to run in the container.
21+
binary_path="${1}"
22+
# Path to directory to write the output to.
23+
output_dir="${2}"
24+
25+
exe_name=$(basename "${binary_path}")
26+
27+
# Identify linked libraries.
28+
libraries=($(ldd "${binary_path}" | awk '{print $(NF-1)}' | grep -v '=>'))
29+
# Add /bin/sh, which we need for Docker imports.
30+
libraries+=('/bin/sh')
31+
32+
mkdir -p "${output_dir}"
33+
34+
# Copy executable and all needed libraries into temporary directory.
35+
cp "${binary_path}" "${output_dir}/${exe_name}"
36+
for lib in "${libraries[@]}"; do
37+
mkdir -p "${output_dir}/$(dirname "$lib")"
38+
# Need -L to make sure we get actual libraries & binaries, not symlinks to
39+
# them.
40+
cp -L "${lib}" "${output_dir}/${lib}"
41+
done

tools/circle.yml

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,43 @@ dependencies:
1313
- go install -tags netgo std
1414
- mkdir -p $(dirname $SRCDIR)
1515
- cp -r $(pwd)/ $SRCDIR
16+
- |
17+
curl -fsSLo shfmt https://github.com/mvdan/sh/releases/download/v1.3.0/shfmt_v1.3.0_linux_amd64 && \
18+
echo "b1925c2c405458811f0c227266402cf1868b4de529f114722c2e3a5af4ac7bb2 shfmt" | sha256sum -c && \
19+
chmod +x shfmt && \
20+
sudo mv shfmt /usr/bin
1621
- |
1722
cd $SRCDIR;
1823
go get \
1924
github.com/fzipp/gocyclo \
2025
github.com/golang/lint/golint \
2126
github.com/kisielk/errcheck \
22-
gopkg.in/mvdan/sh.v1/cmd/shfmt
27+
github.com/fatih/hclfmt
28+
- pip install yapf==0.16.2 flake8==3.3.0
2329

2430
test:
2531
override:
2632
- cd $SRCDIR; ./lint .
2733
- cd $SRCDIR/cover; make
2834
- cd $SRCDIR/socks; make
2935
- cd $SRCDIR/runner; make
36+
- cd $SRCDIR/build; make
37+
38+
deployment:
39+
snapshot:
40+
branch: master
41+
commands:
42+
- docker login -e "$DOCKER_REGISTRY_EMAIL" -u "$DOCKER_REGISTRY_USER" -p "$DOCKER_REGISTRY_PASS" "$DOCKER_REGISTRY_URL"
43+
- |
44+
cd $SRCDIR/build;
45+
for image in $(make images); do
46+
# Tag the built images with the revision of this repo.
47+
docker push "${image}:${GIT_TAG}"
3048
49+
# Tag the built images with something derived from the base images in
50+
# their respective Dockerfiles. So "FROM golang:1.8.0-stretch" as a
51+
# base image would lead to a tag of "1.8.0-stretch"
52+
IMG_TAG=$(make "imagetag-${image#quay.io/weaveworks/build-}")
53+
docker tag "${image}:latest" "${image}:${IMG_TAG}"
54+
docker push "${image}:${IMG_TAG}"
55+
done

0 commit comments

Comments
 (0)