Skip to content

Add ability to drop cluster label after dedupe #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomwilkie opened this issue Oct 9, 2019 · 4 comments · Fixed by #1726
Closed

Add ability to drop cluster label after dedupe #1724

tomwilkie opened this issue Oct 9, 2019 · 4 comments · Fixed by #1726

Comments

@tomwilkie
Copy link
Contributor

A couple of users have asked for this; as we need a cluster label for deduping in the distributors, some people don't have this and adding it will break their graphs.

By "break their graphs", they will cause things like discontinuations in things like recording rules, which for LTS systems is undesirable.

@cstyan is this something we can make an option?

@bboreham
Copy link
Contributor

we need a cluster label for deduping in the distributors

why is this?

@cstyan
Copy link
Contributor

cstyan commented Oct 24, 2019

The cluster label is used to differentiate between HA Prometheus "pairs", the __replica__ label identifies each replica in the pair.

@nbellowe
Copy link

nbellowe commented Nov 4, 2019

This is a similar ask to #1736

Any status updates?

@cstyan
Copy link
Contributor

cstyan commented Nov 4, 2019

There's a PR open: #1726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants