Skip to content

Flake in TestPurger_Metrics() #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bboreham opened this issue Jun 24, 2020 · 4 comments · Fixed by #2777 or #3657
Closed

Flake in TestPurger_Metrics() #2776

bboreham opened this issue Jun 24, 2020 · 4 comments · Fixed by #2777 or #3657

Comments

@bboreham
Copy link
Contributor

--- FAIL: TestPurger_Metrics (0.27s)
    purger_test.go:435: 
        	Error Trace:	purger_test.go:435
        	Error:      	Max difference between 259200 and 172800 allowed is 1, but difference was 86400
        	Test:       	TestPurger_Metrics
FAIL

Failed at https://circleci.com/gh/cortexproject/cortex/33030
Passed at https://circleci.com/gh/cortexproject/cortex/33041

@pracucci
Copy link
Contributor

@sandeepsukhani Could you look at it, please?

@sandeepsukhani
Copy link
Contributor

@sandeepsukhani Could you look at it, please?

The problem was that the test was chasing a moving target.
Opened a PR to fix it #2777

@bboreham
Copy link
Contributor Author

bboreham commented Jan 6, 2021

@sandeepsukhani
Copy link
Contributor

Pushed a possible fix for it #3657.
Most likely it was due to a race between check for expected metric value and updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants