You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use SpanLogger to unify logging and tracing instrumentation code, but we need to call level.Error and log.Error to log and set the error tag on the span in the case of errors. We can keep the current Log and Error functions to satisfy the interfaces but extend Log (or introduce a new function) to detect level=error in the key value pairs passed to the function to also call Error and save users a loc per error handling branch
We use SpanLogger to unify logging and tracing instrumentation code, but we need to call
level.Error
andlog.Error
to log and set the error tag on the span in the case of errors. We can keep the currentLog
andError
functions to satisfy the interfaces but extendLog
(or introduce a new function) to detectlevel=error
in the key value pairs passed to the function to also callError
and save users a loc per error handling branchSee discussion starting here: #2970 (comment)
cc @pstibrany @pracucci
The text was updated successfully, but these errors were encountered: