Skip to content

Report deleted configurations when reporting changed configurations #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jml opened this issue Mar 10, 2017 · 4 comments
Closed

Report deleted configurations when reporting changed configurations #329

jml opened this issue Mar 10, 2017 · 4 comments
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc.

Comments

@jml
Copy link
Contributor

jml commented Mar 10, 2017

From @jml on January 24, 2017 18:31

We currently have private operations for getting changed and created configs. We use this in the recording rules server to make sure we're processing all the configs.

We should also report the IDs of the configs that have been deleted, so we can stop processing those rules.

Copied from original issue: weaveworks/service#1085

@lelenanam
Copy link
Contributor

@jml can we do this by creating new deleted config (the same as last one but with DeletedAt is not null) on deletion and creating new not deleted config for restoring config (the same as last config but with DeletedAt is null)?

@jml
Copy link
Contributor Author

jml commented Jan 5, 2018

I think that would work, yes.

#620 might change the nature of this ticket.

@bboreham
Copy link
Contributor

bboreham commented Jan 9, 2018

Ah, I think I just wrote a longer version at #629 (comment)

@tomwilkie tomwilkie added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Jul 12, 2018
@bboreham
Copy link
Contributor

I believe #629 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc.
Projects
None yet
Development

No branches or pull requests

4 participants