Skip to content

Deprecate -distributor.shard-by-all-labels #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
friedrichg opened this issue Jun 17, 2024 · 2 comments · May be fixed by #6022
Open

Deprecate -distributor.shard-by-all-labels #6021

friedrichg opened this issue Jun 17, 2024 · 2 comments · May be fixed by #6022
Assignees
@tesla59
Labels
difficulty/easy help wanted type/chore Something that needs to be done; not a bug or a feature

Comments

@friedrichg
Copy link
Member

friedrichg commented Jun 17, 2024 •
edited
Loading

Describe the bug
This option is disabled by default and produces imbalanced ingesters, which is never desirable.

Expected behavior
The option should be enabled always and it should not be possible to disable it. We should remove the flag

Additional Context
This should be easy to do, here is a similar PR #5816
Also remove the docs at https://cortexmetrics.io/docs/configuration/arguments/#distributor
@friedrichg friedrichg added type/chore Something that needs to be done; not a bug or a feature help wanted difficulty/easy labels Jun 17, 2024
@tesla59
Copy link
Contributor

tesla59 commented Jun 17, 2024

Hi @friedrichg I would like to work on this issue. Can u please assign it to me?

@tesla59 tesla59 linked a pull request Jun 17, 2024 that will close this issue
Open
3 tasks
@siddhiguptas
Copy link

Hi @friedrichg !!I'd like to work on this! Should I follow the same approach as PR #5816?

@friedrichg friedrichg mentioned this issue May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tesla59 tesla59

Labels
difficulty/easy help wanted type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate -distributor.shard-by-all-labels tesla59/cortex
3 participants
@friedrichg @tesla59 @siddhiguptas