Skip to content

Chunk test flake #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bboreham opened this issue Jan 10, 2018 · 1 comment · Fixed by #656
Closed

Chunk test flake #646

bboreham opened this issue Jan 10, 2018 · 1 comment · Fixed by #656
Assignees
@jml
Labels
type/flaky-test

Comments

@bboreham
Copy link
Contributor

Wonder if this is to do with the from/to times I added in chunksToMatrix

As seen at https://circleci.com/gh/weaveworks/cortex/1550

make: Leaving directory '/go/src/github.com/weaveworks/cortex'

0.07user 0.01system 0:02.73elapsed 2%CPU (0avgtext+0avgdata 13692maxresident)k
0inputs+0outputs (0major+3498minor)pagefaults 0swaps
time docker run  -ti \
		-v /home/ubuntu/cortex/.pkg:/go/pkg \
		-v /home/ubuntu/cortex:/go/src/github.com/weaveworks/cortex \
		quay.io/weaveworks/cortex-build-image test;
make: Entering directory '/go/src/github.com/weaveworks/cortex'

./tools/test -netgo
--- FAIL: TestChunkStore_Get (0.17s)
    --- FAIL: TestChunkStore_Get/foo_/_v1_schema (0.00s)
    	chunk_store_test.go:195: ========= Running query foo with schema v1 schema
    	chunk_store_test.go:225: foo: wrong chunks - 
    		--- want
    		+++ have
    		@@ -1,8 +1,8 @@
    		 (model.Matrix) (len=2 cap=2) (foo{bar="beep", toms="code"} =>
    		-0 @[1515521286.776]
    		+
    		 foo{bar="baz", flip="flop", toms="code"} =>
    		 0 @[1515521286.775]) {
    		- (*model.SampleStream)(0xc4206c32e0)((foo{bar="baz", flip="flop", toms="code"} =>
    		+ (*model.SampleStream)(0xc4200d1980)((foo{bar="baz", flip="flop", toms="code"} =>
    		 0 @[1515521286.775]) {
    		   Metric: (model.Metric) (len=4) (foo{bar="baz", flip="flop", toms="code"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "foo",
    		@@ -17,18 +17,14 @@
    		    }
    		   }
    		  }),
    		- (*model.SampleStream)(0xc4206c3300)((foo{bar="beep", toms="code"} =>
    		-0 @[1515521286.776]) {
    		+ (*model.SampleStream)(0xc4200d19a0)((foo{bar="beep", toms="code"} =>
    		+) {
    		   Metric: (model.Metric) (len=3) (foo{bar="beep", toms="code"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "foo",
    		    (model.LabelName) (len=3) "bar": (model.LabelValue) (len=4) "beep",
    		    (model.LabelName) (len=4) "toms": (model.LabelValue) (len=4) "code"
    		   },
    		-  Values: ([]model.SamplePair) (len=1 cap=1) {
    		-   (model.SamplePair) (0 @[1515521286.776]) {
    		-    Timestamp: (model.Time) (1515521286.776) 1515521286776,
    		-    Value: (model.SampleValue) (0) 0
    		-   }
    		+  Values: ([]model.SamplePair) {
    		   }
    		  })
    		 }
...
FAIL

FAIL	github.com/weaveworks/cortex/pkg/chunk	5.055s

and again on my desktop:

./tools/test -netgo
--- FAIL: TestChunkStore_Get (0.20s)
    --- FAIL: TestChunkStore_Get/{__name__!="foo",_toms="code"}_/_v8_schema (0.00s)
    	chunk_store_test.go:195: ========= Running query {__name__!="foo", toms="code"} with schema v8 schema
    	chunk_store_test.go:225: {__name__!="foo", toms="code"}: wrong chunks - 
    		--- want
    		+++ have
    		@@ -1,17 +1,13 @@
    		 (model.Matrix) (len=1 cap=1) (bar{bar="baz", toms="code"} =>
    		-0 @[1515580128.756]) {
    		- (*model.SampleStream)(0xc4212cc1e0)((bar{bar="baz", toms="code"} =>
    		-0 @[1515580128.756]) {
    		+) {
    		+ (*model.SampleStream)(0xc4212cd680)((bar{bar="baz", toms="code"} =>
    		+) {
    		   Metric: (model.Metric) (len=3) (bar{bar="baz", toms="code"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "bar",
    		    (model.LabelName) (len=3) "bar": (model.LabelValue) (len=3) "baz",
    		    (model.LabelName) (len=4) "toms": (model.LabelValue) (len=4) "code"
    		   },
    		-  Values: ([]model.SamplePair) (len=1 cap=1) {
    		-   (model.SamplePair) (0 @[1515580128.756]) {
    		-    Timestamp: (model.Time) (1515580128.756) 1515580128756,
    		-    Value: (model.SampleValue) (0) 0
    		-   }
    		+  Values: ([]model.SamplePair) {
    		   }
    		  })
    		 }
    --- FAIL: TestChunkStore_Get/{__name__=~"bar",_bar="baz"}_/_v8_schema (0.01s)
    	chunk_store_test.go:195: ========= Running query {__name__=~"bar", bar="baz"} with schema v8 schema
    	chunk_store_test.go:225: {__name__=~"bar", bar="baz"}: wrong chunks - 
    		--- want
    		+++ have
    		@@ -1,32 +1,24 @@
    		 (model.Matrix) (len=2 cap=2) (bar{bar="baz"} =>
    		-0 @[1515580128.756]
    		+
    		 bar{bar="baz", toms="code"} =>
    		-0 @[1515580128.756]) {
    		- (*model.SampleStream)(0xc4212cc1c0)((bar{bar="baz"} =>
    		-0 @[1515580128.756]) {
    		+) {
    		+ (*model.SampleStream)(0xc420228740)((bar{bar="baz"} =>
    		+) {
    		   Metric: (model.Metric) (len=2) (bar{bar="baz"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "bar",
    		    (model.LabelName) (len=3) "bar": (model.LabelValue) (len=3) "baz"
    		   },
    		-  Values: ([]model.SamplePair) (len=1 cap=1) {
    		-   (model.SamplePair) (0 @[1515580128.756]) {
    		-    Timestamp: (model.Time) (1515580128.756) 1515580128756,
    		-    Value: (model.SampleValue) (0) 0
    		-   }
    		+  Values: ([]model.SamplePair) {
    		   }
    		  }),
    		- (*model.SampleStream)(0xc4212cc1e0)((bar{bar="baz", toms="code"} =>
    		-0 @[1515580128.756]) {
    		+ (*model.SampleStream)(0xc420228720)((bar{bar="baz", toms="code"} =>
    		+) {
    		   Metric: (model.Metric) (len=3) (bar{bar="baz", toms="code"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "bar",
    		    (model.LabelName) (len=3) "bar": (model.LabelValue) (len=3) "baz",
    		    (model.LabelName) (len=4) "toms": (model.LabelValue) (len=4) "code"
    		   },
    		-  Values: ([]model.SamplePair) (len=1 cap=1) {
    		-   (model.SamplePair) (0 @[1515580128.756]) {
    		-    Timestamp: (model.Time) (1515580128.756) 1515580128756,
    		-    Value: (model.SampleValue) (0) 0
    		-   }
    		+  Values: ([]model.SamplePair) {
    		   }
    		  })
    		 }
    --- FAIL: TestChunkStore_Get/{__name__=~"bar",_bar="baz",toms!="code"}_/_v8_schema (0.00s)
    	chunk_store_test.go:195: ========= Running query {__name__=~"bar", bar="baz",toms!="code"} with schema v8 schema
    	chunk_store_test.go:225: {__name__=~"bar", bar="baz",toms!="code"}: wrong chunks - 
    		--- want
    		+++ have
    		@@ -1,16 +1,12 @@
    		 (model.Matrix) (len=1 cap=1) (bar{bar="baz"} =>
    		-0 @[1515580128.756]) {
    		- (*model.SampleStream)(0xc4212cc1c0)((bar{bar="baz"} =>
    		-0 @[1515580128.756]) {
    		+) {
    		+ (*model.SampleStream)(0xc4212cc0e0)((bar{bar="baz"} =>
    		+) {
    		   Metric: (model.Metric) (len=2) (bar{bar="baz"}) {
    		    (model.LabelName) (len=8) "__name__": (model.LabelValue) (len=3) "bar",
    		    (model.LabelName) (len=3) "bar": (model.LabelValue) (len=3) "baz"
    		   },
    		-  Values: ([]model.SamplePair) (len=1 cap=1) {
    		-   (model.SamplePair) (0 @[1515580128.756]) {
    		-    Timestamp: (model.Time) (1515580128.756) 1515580128756,
    		-    Value: (model.SampleValue) (0) 0
    		-   }
    		+  Values: ([]model.SamplePair) {
    		   }
    		  })
    		 }
FAIL
FAIL	github.com/weaveworks/cortex/pkg/chunk	4.687s
@jml
Copy link
Contributor

jml commented Jan 15, 2018

Note:

  • not restricted to schema
  • not restricted to one query

@jml jml self-assigned this Jan 16, 2018
@jml jml mentioned this issue Jan 16, 2018
Merged
@jml jml closed this as completed in #656 Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jml jml

Labels
type/flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky chunk tests by being explicit about now cortexproject/cortex
2 participants
@jml @bboreham