Skip to content

Data queuing inside Ingester for one table stalls other tables #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bboreham opened this issue Feb 5, 2018 · 2 comments
Closed

Data queuing inside Ingester for one table stalls other tables #684

bboreham opened this issue Feb 5, 2018 · 2 comments

Comments

@bboreham
Copy link
Contributor

bboreham commented Feb 5, 2018

At least with the DynamoDB back, end, where we write to multiple different tables, the code makes no attempt to keep writing chunks to some tables while others are queued up. With different provisioning rates for different tables this can result in a blow-up in chunk queues.

@bboreham
Copy link
Contributor Author

Currently there are multiple goroutines to write to the backend store, but:

  • they are only given a set of chunks+index writes for one timeseries, so write to the same hashkey multiple times when there are multiple chunks queued for a series.
  • they are given work to do in priority order based on how old the oldest chunk is.

To avoid hotspotting, the code should look across all writes that are ready, grab as many as will efficiently fit in a batch, and split them up so writes in the same batch have different hashkeys.

@gouthamve
Copy link
Contributor

Closing this as this not so much of an issue nowadays with dynamo updates and schema changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants