Skip to content

Write order errors should be 400, not 500 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jml opened this issue Oct 25, 2016 · 1 comment
Closed

Write order errors should be 400, not 500 #72

jml opened this issue Oct 25, 2016 · 1 comment

Comments

@jml
Copy link
Contributor

jml commented Oct 25, 2016

A couple of times today, we've got:

time="2016-10-25T16:47:27Z" level=info msg="POST /push (500) 420.17µs"
time="2016-10-25T16:47:29Z" level=error msg="append err: sample timestamp out of order" source="server.go:125"

These represent invalid input by the client and should be represented as 400s, rather than 500s.
@jml jml mentioned this issue Oct 25, 2016
Merged
@jml
Copy link
Contributor Author

jml commented Nov 4, 2016

Fixed by #73

@jml jml closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jml