Skip to content

Use newest upstream Alertmanager packages with memberlist support #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliusv opened this issue Apr 10, 2018 · 3 comments · Fixed by #929
Closed

Use newest upstream Alertmanager packages with memberlist support #793

juliusv opened this issue Apr 10, 2018 · 3 comments · Fixed by #929
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. type/chore Something that needs to be done; not a bug or a feature

Comments

@juliusv
Copy link
Contributor

juliusv commented Apr 10, 2018

Upstream Alertmanager has undergone major changes with regards to how it syncs notification state between cluster replicas. Instead of https://github.com/weaveworks/mesh, it now uses https://github.com/hashicorp/memberlist. We should update Cortex to work with the upstream changes so that we are not blocked to pick up other relevant upstream features.

@juliusv juliusv added the type/chore Something that needs to be done; not a bug or a feature label Apr 10, 2018
@bboreham
Copy link
Contributor

I believe there was a blocker in that we currently force down an updated list of peers, and memberlist doesn't let us do that. But I can't find the details right now.

@juliusv
Copy link
Contributor Author

juliusv commented Jul 25, 2018

@bboreham That is correct. Or at least Alertmanager's abstraction of memberlist in https://github.com/prometheus/alertmanager/blob/master/cluster/cluster.go didn't allow for that last time I checked.

@bboreham
Copy link
Contributor

bboreham commented Aug 9, 2018

To update on this, I have managed to compile and run Cortex with recent upstream Alertmanager code; now I am figuring out how to test it.

@tomwilkie tomwilkie added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants