Skip to content

Commit c00f773

Browse files
committed
update tests to skip replica reads if not supported
1 parent 4b872ca commit c00f773

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

test/test_integration_subdoc.cxx

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,15 +1832,17 @@ TEST_CASE("integration: subdoc invalid_argument if empty specs", "[integration]"
18321832
auto lookupin_resp = test::utils::execute(integration.cluster, lookupin_req);
18331833
REQUIRE(lookupin_resp.ctx.ec() == couchbase::errc::common::invalid_argument);
18341834

1835-
couchbase::core::operations::lookup_in_any_replica_request lookupin_any_replica_req{ id };
1836-
auto lookupin_any_replica_resp =
1837-
test::utils::execute(integration.cluster, lookupin_any_replica_req);
1838-
REQUIRE(lookupin_any_replica_resp.ctx.ec() == couchbase::errc::common::invalid_argument);
1839-
1840-
couchbase::core::operations::lookup_in_all_replicas_request lookup_in_all_replicas_req{ id };
1841-
auto lookup_in_all_replicas_resp =
1842-
test::utils::execute(integration.cluster, lookup_in_all_replicas_req);
1843-
REQUIRE(lookup_in_all_replicas_resp.ctx.ec() == couchbase::errc::common::invalid_argument);
1835+
if (integration.has_bucket_capability("subdoc.ReplicaRead")) {
1836+
couchbase::core::operations::lookup_in_any_replica_request lookupin_any_replica_req{ id };
1837+
auto lookupin_any_replica_resp =
1838+
test::utils::execute(integration.cluster, lookupin_any_replica_req);
1839+
REQUIRE(lookupin_any_replica_resp.ctx.ec() == couchbase::errc::common::invalid_argument);
1840+
1841+
couchbase::core::operations::lookup_in_all_replicas_request lookup_in_all_replicas_req{ id };
1842+
auto lookup_in_all_replicas_resp =
1843+
test::utils::execute(integration.cluster, lookup_in_all_replicas_req);
1844+
REQUIRE(lookup_in_all_replicas_resp.ctx.ec() == couchbase::errc::common::invalid_argument);
1845+
}
18441846

18451847
couchbase::core::operations::mutate_in_request mutatein_req{ id };
18461848
auto mutatein_resp = test::utils::execute(integration.cluster, mutatein_req);
@@ -1860,14 +1862,16 @@ TEST_CASE("integration: subdoc invalid_argument if empty specs", "[integration]"
18601862
auto [lookupin_err, lookupin_resp] = collection.lookup_in(key, {}).get();
18611863
REQUIRE(lookupin_err.ec() == couchbase::errc::common::invalid_argument);
18621864

1863-
auto [lookup_in_any_replica_err, lookup_in_any_replica_resp] =
1864-
collection.lookup_in_any_replica(key, {}).get();
1865-
REQUIRE(lookup_in_any_replica_err.ec() == couchbase::errc::common::invalid_argument);
1865+
if (integration.has_bucket_capability("subdoc.ReplicaRead")) {
1866+
auto [lookup_in_any_replica_err, lookup_in_any_replica_resp] =
1867+
collection.lookup_in_any_replica(key, {}).get();
1868+
REQUIRE(lookup_in_any_replica_err.ec() == couchbase::errc::common::invalid_argument);
18661869

1867-
auto [lookup_in_all_replicas_err, lookup_in_all_replicas_resp] =
1868-
collection.lookup_in_all_replicas(key, {}).get();
1869-
REQUIRE(lookup_in_all_replicas_err.ec() == couchbase::errc::common::invalid_argument);
1870-
REQUIRE(lookup_in_all_replicas_resp.empty());
1870+
auto [lookup_in_all_replicas_err, lookup_in_all_replicas_resp] =
1871+
collection.lookup_in_all_replicas(key, {}).get();
1872+
REQUIRE(lookup_in_all_replicas_err.ec() == couchbase::errc::common::invalid_argument);
1873+
REQUIRE(lookup_in_all_replicas_resp.empty());
1874+
}
18711875

18721876
auto [mutate_in_err, mutate_in_resp] = collection.mutate_in(key, {}).get();
18731877
REQUIRE(mutate_in_err.ec() == couchbase::errc::common::invalid_argument);

0 commit comments

Comments
 (0)