CXXCBC-431: Add check for history retention bucket capability in collection create/update #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
requested changes
Jan 11, 2024
Member
avsej
left a comment
avsej
left a comment
There was a problem hiding this comment.
Looks like all severs return different kinds of errors
DemetrisChr
force-pushed
the
dedup-not-allowed-this-type
branch
from
1a93cea to
854ccf5
Compare
…sponse with bucket cap check
DemetrisChr
force-pushed
the
dedup-not-allowed-this-type
branch
from
854ccf5 to
bc0561a
Compare
DemetrisChr
changed the title
DemetrisChr
changed the title
avsej
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message when the bucket does not support history retention has changed in newer server versions. Replace the error message checks for
feature_not_availablewith a bucket capability check before sending the collection create/update request.