Skip to content

Conversation

@DemetrisChr
Copy link
Contributor

Motivation

Make the SDK consistent with the management RFC revision/clarification in couchbaselabs/sdk-rfcs#116

Changes

  • Rename fields parameter to keys in the Public API's create_index()
  • Encode each index key provided to create_index() by surrounding them with backticks
  • Add unit test for the encoding & update integration test to reflect these changes

@DemetrisChr DemetrisChr force-pushed the CXXCBC-191-index-key-encoding branch from aa7e834 to 640595d Compare February 9, 2024 15:20
@DemetrisChr DemetrisChr force-pushed the CXXCBC-191-index-key-encoding branch from 640595d to c87ebf1 Compare February 9, 2024 16:43
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DemetrisChr DemetrisChr merged commit c9cd5fa into couchbase:main Feb 12, 2024
@DemetrisChr DemetrisChr deleted the CXXCBC-191-index-key-encoding branch February 12, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants