Skip to content

Embedded PDB files break RestoreOriginalFile #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharwell opened this issue Mar 8, 2019 · 1 comment
Closed

Embedded PDB files break RestoreOriginalFile #362

sharwell opened this issue Mar 8, 2019 · 1 comment

Comments

@sharwell
Copy link
Contributor

sharwell commented Mar 8, 2019

This code assumes the PDB file is separate from the assembly. It results in an MSBuild error when the PDB is embedded within the assembly (<DebugType>embedded</DebugType>).

https://github.com/tonerdo/coverlet/blob/062b907735901bdf3ad9d4d40953f53a4fe3f364/src/coverlet.core/Helpers/InstrumentationHelper.cs#L110-L114
This was referenced Mar 8, 2019
Merged
Closed
@sharwell sharwell mentioned this issue Apr 8, 2019
Merged
@sharwell
Copy link
Contributor Author

This was fixed by #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharwell