add toString overload for AccessKind

Author: sdkrystian

include/mrdox/Metadata/Symbols.hpp

@@ -19,6 +19,7 @@
 #include <cstdint>
 #include <cstring>
 #include <compare>
+#include <string_view>
 
 namespace clang {
 namespace mrdox {
@@ -138,6 +139,10 @@ enum class AccessKind
     None
 };
 
+MRDOX_DECL
+std::string_view
+toString(AccessKind access);
+
 /** Return the result of comparing s0 to s1.
 
     This function returns true if the string

source/-XML/XMLTags.hpp

@@ -108,22 +108,9 @@ struct Attribute
     Attribute(
         AccessKind access)
         : name("access")
-        , value(
-            [access]
-            {
-                switch(access)
-                {
-                case AccessKind::None:
-                    return std::string();
-                case AccessKind::Public: return std::string("public");
-                case AccessKind::Protected: return std::string("protected");
-                case AccessKind::Private: return std::string("private");
-                default:
-                    // unknown Access
-                    MRDOX_UNREACHABLE();
-                }
-            }())
-        , pred(access == AccessKind::Private || access == AccessKind::Protected)
+        , value(toString(access))
+        , pred(access == AccessKind::Private ||
+            access == AccessKind::Protected)
     {
     }
 

source/-adoc/AdocWriter.hpp

@@ -23,21 +23,6 @@ namespace clang {
 namespace mrdox {
 namespace adoc {
 
-inline
-llvm::StringRef
-toString(AccessKind access) noexcept
-{
-    switch(access)
-    {
-    case AccessKind::Public: return "public";
-    case AccessKind::Protected: return "protected";
-    case AccessKind::Private: return "private";
-    default:
-        // unknown access
-        MRDOX_UNREACHABLE();
-    }
-}
-
 class AdocWriter
 {
     template<class T>

source/Metadata/Symbols.cpp

@@ -15,6 +15,25 @@
 namespace clang {
 namespace mrdox {
 
+std::string_view
+toString(AccessKind access)
+{
+    switch(access)
+    {
+    case AccessKind::Public:
+        return "public";
+    case AccessKind::Private:
+        return "private";
+    case AccessKind::Protected:
+        return "protected";
+    case AccessKind::None:
+        return "none";
+    default:
+        // unknown AccessKind
+        MRDOX_UNREACHABLE();
+    }
+}
+
 // Better have 8 bits per byte, otherwise
 // we are going to be having some problems...
 static_assert(CHAR_BIT == 8);