public interface tidying

Author: vinniefalco

include/mrdox/Corpus.hpp

@@ -65,10 +65,10 @@ class MRDOX_VISIBLE
 
     /** Return the Info with the matching ID, or nullptr.
     */
-    /** @{ */
-    MRDOX_DECL virtual Info* find(SymbolID const& id) noexcept = 0;
-    MRDOX_DECL virtual Info const* find(SymbolID const& id) const noexcept = 0;
-    /** @} */
+    MRDOX_DECL
+    virtual
+    Info const*
+    find(SymbolID const& id) const noexcept = 0;
 
     /** Return true if an Info with the specified symbol ID exists.
     */

source/api/Config.cpp

@@ -160,7 +160,7 @@ loadConfigFile(
 
     // ensure fileName is a regular file
     fs::file_status stat;
-    if(ec = fs::status(fileName, stat))
+    if((ec = fs::status(fileName, stat)))
         return {};
     if(stat.type() != fs::file_type::regular_file)
     {
@@ -180,7 +180,7 @@ loadConfigFile(
     // calculate the working directory
     llvm::SmallString<64> workingDir(fileName);
     path::remove_filename(workingDir);
-    if(ec = fs::make_absolute(workingDir))
+    if((ec = fs::make_absolute(workingDir)))
         return {};
 
     // attempt to create the config

source/api/CorpusImpl.hpp

@@ -33,6 +33,10 @@ class CorpusImpl : public Corpus
     {
     }
 
+    Info*
+    find(
+        SymbolID const& id) noexcept;
+
 private:
     std::shared_ptr<Config const> const&
     config() const noexcept override
@@ -46,10 +50,6 @@ class CorpusImpl : public Corpus
         return index_;
     }
 
-    Info*
-    find(
-        SymbolID const& id) noexcept override;
-
     Info const*
     find(
         SymbolID const& id) const noexcept override;

source/api/Support/SafeNames.cpp

@@ -42,7 +42,7 @@ class SafeNames::
     {
         prefix_.reserve(512);
         corpus_.visit(globalNamespaceID, *this);
-        map.try_emplace(llvm::toStringRef(EmptySID), std::string());
+        /* auto result =*/ map.try_emplace(llvm::toStringRef(EmptySID), std::string());
 
     #ifndef NDEBUG
         //for(auto const& N : map)
@@ -59,7 +59,7 @@ class SafeNames::
     {
         prefix_.reserve(512);
         corpus_.visit(globalNamespaceID, *this);
-        map.try_emplace(llvm::toStringRef(EmptySID), std::string());
+        /* auto result =*/ map.try_emplace(llvm::toStringRef(EmptySID), std::string());
         if(os_)
             *os_ << "\n\n";
     }
@@ -161,7 +161,7 @@ class SafeNames::
                 s.append(getSafe(**it0));
                 if(os_)
                     *os_ << getSafe(**it0) << "\n";
-                auto result = map.try_emplace(
+                /*auto result =*/ map.try_emplace(
                     llvm::toStringRef((*it0)->id),
                     std::move(s));
                 it0 = it;
@@ -179,7 +179,7 @@ class SafeNames::
                 if(os_)
                     *os_ << suffix << "\n";
                 s.append(suffix);
-                auto result = map.try_emplace(
+                /*auto result =*/ map.try_emplace(
                     llvm::toStringRef(it0[i]->id),
                     std::move(s));
             }

source/api/_adoc/AdocSinglePageWriter.cpp

@@ -195,7 +195,7 @@ visit(
         if(! visit(*I))
             return false;
     for(auto const& I : functionOverloads.list)
-        if(! visit(I))
+        if(! visitOverloads(I))
             return false;
     for(auto const& I : typedefList)
         if(! visit(*I))
@@ -220,7 +220,7 @@ visit(
 
 bool
 AdocSinglePageWriter::
-visit(
+visitOverloads(
     OverloadInfo const& I)
 {
     // this is the "overload resolution landing page"
@@ -268,6 +268,7 @@ visit(
     return true;
 }
 
+#if 0
 bool
 AdocSinglePageWriter::
 visitOverloads(
@@ -281,7 +282,7 @@ visitOverloads(
     // Location
     writeLocation(*I.Functions.front());
 
-    // AnyList of overloads
+    // List of overloads
     os_ << '\n';
     for(auto const I : I.Functions)
     {
@@ -294,7 +295,7 @@ visitOverloads(
     os_ << "\n//-\n";
     writeBrief(I.Functions.front()->javadoc, true);
 
-    // AnyList of descriptions
+    // List of descriptions
     for(auto const I : I.Functions)
     {
         os_ << ". ";
@@ -308,6 +309,7 @@ visitOverloads(
 
     return true;
 }
+#endif
 
 } // adoc
 } // mrdox

source/api/_adoc/AdocSinglePageWriter.hpp

@@ -44,13 +44,13 @@ class AdocSinglePageWriter
 
     bool visit(NamespaceInfo const&) override;
     bool visit(RecordInfo const&) override;
-    bool visit(OverloadInfo const&);
+    bool visitOverloads(OverloadInfo const&);
     bool visit(FunctionInfo const&) override;
     bool visit(TypedefInfo const&) override;
     bool visit(EnumInfo const&) override;
     bool visit(VariableInfo const&) override;
 
-    bool visitOverloads(Info const& P, OverloadInfo const&);
+    //bool visitOverloads(Info const& P, OverloadInfo const&);
 };
 
 } // adoc