remove IsMethod

Author: vinniefalco

include/mrdox/Metadata/Function.hpp

@@ -74,7 +74,6 @@ union FnFlags1
 // Info for functions.
 struct FunctionInfo : SymbolInfo
 {
-    bool IsMethod = false; // Indicates whether this function is a class method.
     Reference Parent;      // Reference to the parent class decl for this method.
     TypeInfo ReturnType;   // Info about the return type of this function.
     llvm::SmallVector<FieldTypeInfo, 4> Params; // List of parameters.

source/lib/api/AST/ASTVisitor.cpp

@@ -797,17 +797,11 @@ constructFunction(
         I.specs1.nodiscardSpelling = attr->getSemanticSpelling();
     }
 
-    if constexpr(! std::derived_from<DeclTy, CXXMethodDecl>)
-    {
-        I.IsMethod = false;
-    }
-
     //
     // CXXMethodDecl
     //
     if constexpr(std::derived_from<DeclTy, CXXMethodDecl>)
     {
-        I.IsMethod = true;
         NamedDecl const* PD = nullptr;
         if(auto const* SD = dyn_cast<ClassTemplateSpecializationDecl>(D->getParent()))
             PD = SD->getSpecializedTemplate();

source/lib/api/AST/AnyBlock.hpp

@@ -919,8 +919,6 @@ class FunctionBlock
     {
         switch(ID)
         {
-        case FUNCTION_IS_METHOD:
-            return decodeRecord(R, I->IsMethod, Blob);
         case FUNCTION_BITS:
             return decodeRecord(R, {&I->specs0.raw, &I->specs1.raw}, Blob);
         default:

source/lib/api/AST/BitcodeWriter.cpp

@@ -263,7 +263,6 @@ RecordIDNameMap = []()
         {JAVADOC_PARAM_DIRECTION, {"JavadocParamDirection", &Integer32Abbrev}},
         {MEMBER_TYPE_NAME, {"Name", &StringAbbrev}},
         {MEMBER_TYPE_ACCESS, {"Access", &Integer32Abbrev}},
-        {FUNCTION_IS_METHOD, {"IsMethod", &BoolAbbrev}},
         {FUNCTION_BITS, {"Bits", &Integer32ArrayAbbrev}},
         {RECORD_TAG_TYPE, {"TagType", &Integer32Abbrev}},
         {RECORD_IS_TYPE_DEF, {"IsTypeDef", &BoolAbbrev}},
@@ -321,7 +320,7 @@ RecordsByBlock{
     {BI_FIELD_TYPE_BLOCK_ID, {FIELD_TYPE_NAME, FIELD_DEFAULT_VALUE, FIELD_ATTRIBUTES}},
     // FunctionInfo
     {BI_FUNCTION_BLOCK_ID,
-        {FUNCTION_IS_METHOD, FUNCTION_BITS}},
+        {FUNCTION_BITS}},
     // Javadoc
     {BI_JAVADOC_BLOCK_ID,
         {}},
@@ -808,7 +807,6 @@ emitBlock(
     StreamSubBlockGuard Block(Stream, BI_FUNCTION_BLOCK_ID);
     emitInfoPart(I);
     emitSymbolPart(I);
-    emitRecord(I.IsMethod, FUNCTION_IS_METHOD);
     emitRecord({I.specs0.raw, I.specs1.raw}, FUNCTION_BITS);
     emitBlock(I.Parent, FieldId::F_parent);
     emitBlock(I.ReturnType);

source/lib/api/Metadata/Reduce.cpp

@@ -183,8 +183,6 @@ void merge(RecordInfo& I, RecordInfo&& Other)
 void merge(FunctionInfo& I, FunctionInfo&& Other)
 {
     Assert(canMerge(I, Other));
-    if(! I.IsMethod)
-        I.IsMethod = Other.IsMethod;
     if (I.ReturnType.Type.id == EmptySID && I.ReturnType.Type.Name == "")
         I.ReturnType = std::move(Other.ReturnType);
     if (I.Parent.id == EmptySID && I.Parent.Name == "")