squelch unused private members

Author: vinniefalco

CMakeLists.txt

@@ -33,6 +33,12 @@ set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_MINSIZEREL ON CACHE STRING "")
 set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELWITHDEBINFO ON CACHE STRING "")
 option(MRDOX_BUILD_TESTS "Build tests" ON)
 
+if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    set(MRDOX_GCC ON)
+elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang$")
+    set(MRDOX_CLANG ON)
+endif()
+
 #-------------------------------------------------
 #
 # Dependencies
@@ -114,6 +120,13 @@ if (WIN32)
     endif()
 endif ()
 
+if (MRDOX_CLANG)
+    target_compile_options(
+        mrdox_lib
+        PUBLIC
+        -Wno-unused-private-field)
+endif ()
+
 source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} PREFIX "" FILES CMakeLists.txt)
 source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/include/mrdox PREFIX "include" FILES ${LIB_INCLUDES})
 source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/source/lib PREFIX "source" FILES ${LIB_SOURCES})

include/mrdox/Corpus.hpp

@@ -47,6 +47,33 @@ class Corpus
     std::vector<SymbolID> allSymbols;
 
 public:
+    //--------------------------------------------
+    //
+    // Static Functions
+    //
+    //--------------------------------------------
+
+    /** Store the Info in the tool results, keyed by SymbolID.
+    */
+    static
+    void
+    reportResult(
+        tooling::ExecutionContext& exc,
+        Info const& I);
+
+    /** Build the intermediate representation of the code being documented.
+
+        @par R The diagnostic reporting object to
+        use for delivering errors and information.
+    */
+    [[nodiscard]]
+    static
+    std::unique_ptr<Corpus>
+    build(
+        tooling::ToolExecutor& ex,
+        Config const& config,
+        Reporter& R);
+
     //--------------------------------------------
     //
     // Observers
@@ -102,9 +129,11 @@ class Corpus
         return *p;
     }
 
+    //--------------------------------------------
     //
     // Modifiers
     //
+    //--------------------------------------------
 
     /** Canonicalize the contents of the object.
 
@@ -117,12 +146,13 @@ class Corpus
     bool
     canonicalize(Reporter& R);
 
+private:
     //--------------------------------------------
     //
     // Implementation
     //
     //--------------------------------------------
-private:
+
     /** Insert this element and all its children into the Corpus.
 
         @par Thread Safety
@@ -137,33 +167,6 @@ class Corpus
     */
     void insertIntoIndex(Info const& I);
 
-    //--------------------------------------------
-    //
-    // Static Functions
-    //
-    //--------------------------------------------
-public:
-    /** Store the Info in the tool results, keyed by SymbolID.
-    */
-    static
-    void
-    reportResult(
-        tooling::ExecutionContext& exc,
-        Info const& I);
-
-    /** Build the intermediate representation of the code being documented.
-
-        @par R The diagnostic reporting object to
-        use for delivering errors and information.
-    */
-    [[nodiscard]]
-    static
-    std::unique_ptr<Corpus>
-    build(
-        tooling::ToolExecutor& ex,
-        Config const& config,
-        Reporter& R);
-
 private:
     Corpus() = default;
 

source/lib/Asciidoc.cpp

@@ -430,8 +430,6 @@ toString(TagTypeKind k) noexcept
     case TagTypeKind::TTK_Union: return "union";
     case TagTypeKind::TTK_Class: return "class";
     case TagTypeKind::TTK_Enum: return "enum";
-    default:
-        llvm_unreachable("unknown TagTypeKind");
     }
 }
 

source/lib/Corpus.cpp

@@ -189,16 +189,10 @@ build(
             R.first->second.emplace_back(Value);
         });
 
-    // Collects all Infos according to their unique
-    // USR value. This map is added to from the thread
-    // pool below and is protected by this mutex.
-    llvm::sys::Mutex USRToInfoMutex;
-
     // First reducing phase (reduce all decls into one info per decl).
     llvm::outs() << "Reducing " << USRToBitcode.size() << " declarations\n";
     std::atomic<bool> GotFailure;
     GotFailure = false;
-    llvm::sys::Mutex IndexMutex;
     // VFALCO Should this concurrency be a command line option?
     llvm::ThreadPool Pool(llvm::hardware_concurrency(tooling::ExecutorConcurrency));
     for (auto& Group : USRToBitcode)
@@ -276,7 +270,7 @@ build(
             });
     }
 
-    return std::move(up);
+    return up;
 }
 
 } // mrdox