tidy up Javadoc

Author: vinniefalco

include/mrdox/Metadata/Enum.hpp

@@ -27,6 +27,19 @@ namespace mrdox {
 // Information for a single possible value of an enumeration.
 struct EnumValueInfo
 {
+    llvm::SmallString<16> Name;
+
+    // The computed value of the enumeration constant. This could be the result of
+    // evaluating the ValueExpr, or it could be automatically generated according
+    // to C rules.
+    llvm::SmallString<16> Value;
+
+    // Stores the user-supplied initialization expression for this enumeration
+    // constant. This will be empty for implicit enumeration values.
+    llvm::SmallString<16> ValueExpr;
+
+    //--------------------------------------------
+
     explicit
     EnumValueInfo(
         llvm::StringRef Name = llvm::StringRef(),
@@ -38,23 +51,15 @@ struct EnumValueInfo
     {
     }
 
+#if 0
+    // VFALCO What was this for?
     bool operator==(EnumValueInfo const& Other) const
     {
         return
             std::tie(Name, Value, ValueExpr) ==
             std::tie(Other.Name, Other.Value, Other.ValueExpr);
     }
-
-    llvm::SmallString<16> Name;
-
-    // The computed value of the enumeration constant. This could be the result of
-    // evaluating the ValueExpr, or it could be automatically generated according
-    // to C rules.
-    llvm::SmallString<16> Value;
-
-    // Stores the user-supplied initialization expression for this enumeration
-    // constant. This will be empty for implicit enumeration values.
-    llvm::SmallString<16> ValueExpr;
+#endif
 };
 
 //------------------------------------------------

include/mrdox/Metadata/FieldType.hpp

@@ -44,6 +44,8 @@ struct FieldTypeInfo
     {
     }
 
+#if 0
+    // VFALCO What was this for?
     bool
     operator==(
         FieldTypeInfo const& Other) const
@@ -52,6 +54,7 @@ struct FieldTypeInfo
             std::tie(Type, Name, DefaultValue) ==
             std::tie(Other.Type, Other.Name, Other.DefaultValue);
     }
+#endif
 };
 
 } // mrdox

include/mrdox/Metadata/Javadoc.hpp

@@ -24,7 +24,8 @@ namespace mrdox {
 
 /** A processed Doxygen-style comment attached to a declaration.
 */
-struct Javadoc
+struct MRDOX_VISIBLE
+    Javadoc
 {
     using String = std::string;
 
@@ -290,16 +291,19 @@ struct Javadoc
 
     //--------------------------------------------
 
-    Javadoc() noexcept = default;
+    MRDOX_DECL
+    Javadoc() noexcept;
 
     /** Constructor
     */
+    MRDOX_DECL
     explicit
     Javadoc(
         List<Block> blocks);
 
     /** Return true if this is empty
     */
+    MRDOX_DECL
     bool
     empty() const noexcept;
 
@@ -339,10 +343,11 @@ struct Javadoc
         output format.
     */
     /** @{ */
-    bool operator==(Javadoc const&) const noexcept;
-    bool operator!=(Javadoc const&) const noexcept;
+    MRDOX_DECL bool operator==(Javadoc const&) const noexcept;
+    MRDOX_DECL bool operator!=(Javadoc const&) const noexcept;
     /* @} */
 
+    MRDOX_DECL
     List<Block>::const_iterator
     findBrief() const noexcept;
 
@@ -362,7 +367,9 @@ struct Javadoc
         @li Otherwise, the brief is set to a
             null pointer to indicate absence.
     */
-    void calculateBrief();
+    MRDOX_DECL 
+    void
+    calculateBrief();
 
     //--------------------------------------------
 

source/api/Metadata/Javadoc.cpp

@@ -33,6 +33,9 @@ static_assert(a_Node<Javadoc::Code>);
 
 //------------------------------------------------
 
+Javadoc::
+Javadoc() noexcept = default;
+
 Javadoc::
 Javadoc(
     List<Block> blocks)