fix: LookupCallback has virtual destructor

alandefreitas · alandefreitas · commit c5dc7ae664b1 · 2024-01-19T17:59:27.000-03:00
diff --git a/src/lib/Lib/Lookup.hpp b/src/lib/Lib/Lookup.hpp
@@ -62,6 +62,7 @@ class SymbolLookup
 
     struct LookupCallback
     {
+        virtual ~LookupCallback() = default;
         virtual bool operator()(const Info&) = 0;
     };
 
@@ -139,6 +140,8 @@ makeHandler(Fn& fn)
         Fn& fn_;
 
     public:
+        ~LookupCallbackImpl() override = default;
+
         LookupCallbackImpl(Fn& fn)
             : fn_(fn)
         {

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ class SymbolLookup`
`62`	`62`
`63`	`63`	`struct LookupCallback`
`64`	`64`	`{`
	`65`	`+ virtual ~LookupCallback() = default;`
`65`	`66`	`virtual bool operator()(const Info&) = 0;`
`66`	`67`	`};`
`67`	`68`
`@@ -139,6 +140,8 @@ makeHandler(Fn& fn)`
`139`	`140`	`Fn& fn_;`
`140`	`141`
`141`	`142`	`public:`
	`143`	`+ ~LookupCallbackImpl() override = default;`
	`144`	`+`
`142`	`145`	`LookupCallbackImpl(Fn& fn)`
`143`	`146`	`: fn_(fn)`
`144`	`147`	`{`