Skip to content

Commit 0a3146c

Browse files
authored
Resolve metrics AST contract puzzle (#1279)
Co-authored-by: Beeeeeeee-c <Beeeeeeee-c@users.noreply.github.com>
1 parent be4499d commit 0a3146c

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

test/config/test_config.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,6 @@
77

88

99
def test_each_metric_in_config_accepts_ast():
10-
'''
11-
TODO #813:30min/DEV Ensure All Metrics Accept `ast: AST` Parameter with Type Hints
12-
Verify that all metrics in the config accept an AST parameter with proper type hints.
13-
Probable solutions:
14-
1. Every metric factory in patterns_config["metrics"] produces a metric with:
15-
- A parameter named "ast" in its call signature
16-
- The "ast" parameter properly annotated as `aibolit.ast_framework.ast.AST` or a subclass
17-
2. Remove any metrics that cannot comply with this interface.
18-
Once all metrics meet requirements, remove the decorator.
19-
'''
2010
patterns_config = Config.get_patterns_config()
2111
excluded_metric_codes = set(patterns_config['metrics_exclude'])
2212
ast_compatible_metrics = [

0 commit comments

Comments
 (0)