Fix external methods typing checks

Author: Beeeeeeee-c

aibolit/metrics/external_methods_called/external_methods_called.py

@@ -29,7 +29,10 @@ def _external_method_names_called(self) -> Set[str]:
         local_methods = self._local_method_names()
         return set(
             node.member
-            for node in self.ast.proxy_nodes(ASTNodeType.METHOD_INVOCATION)
+            for node in self.ast.proxy_nodes(
+                ASTNodeType.METHOD_INVOCATION,
+                ASTNodeType.SUPER_METHOD_INVOCATION,
+            )
             if node.member not in local_methods
         )
 

test/metrics/external_methods_called/SuperMethodCall.java

@@ -0,0 +1,9 @@
+// SPDX-FileCopyrightText: Copyright (c) 2019-2026 Aibolit
+// SPDX-License-Identifier: MIT
+
+public class SuperMethodCall {
+
+    public String value() {
+        return super.toString();
+    }
+}

test/metrics/external_methods_called/test_external_methods_called.py

@@ -29,7 +29,9 @@ def test_external_method_calls(self):
 
     def test_external_method_calls_from_filepath(self):
         self.assertEqual(
-            ExternalMethodsCalled().value(Path(self.dir_path, 'ExternalMethodCalls.java')),
+            ExternalMethodsCalled().value(
+                Path(self.dir_path, 'ExternalMethodCalls.java')  # ty: ignore[invalid-argument-type]
+            ),
             2,
             'Could not calculate external methods from a file path'
         )
@@ -55,5 +57,12 @@ def test_local_method_call_is_not_external(self):
             'Could not ignore local method calls'
         )
 
+    def test_super_method_call_is_external(self):
+        self.assertEqual(
+            ExternalMethodsCalled().value(self._ast('SuperMethodCall.java')),
+            1,
+            'Could not count super method calls as external'
+        )
+
     def _ast(self, filename):
         return AST.build_from_javalang(build_ast(Path(self.dir_path, filename)))

test/scripts/test_calculate_metrics.py

@@ -12,8 +12,9 @@ def load_calculate_metrics_module():
         raise RuntimeError(f'Failed to load module spec from {script_path}')
     if spec.loader is None:
         raise RuntimeError(f'Failed to load module loader from {script_path}')
+    loader = spec.loader
     module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
+    loader.exec_module(module)
     return module