mypy: Make it work, part 3

Author: amotl

docs/source/crate_operator_ext.py

@@ -47,7 +47,7 @@ def run_apidoc(_):
 
 def missing_reference(
     app: Sphinx, env: BuildEnvironment, node: pending_xref, contnode: Element
-) -> Element:
+) -> None:
     """
     Remove or resolve references to third party packages.
 
@@ -70,7 +70,6 @@ def missing_reference(
             node.attributes["reftarget"] = "aiopg." + reftarget[17:]
         elif reftarget.startswith("aiopg.cursor."):
             node.attributes["reftarget"] = "aiopg." + reftarget[13:]
-    return node
 
 
 def setup(app):

tests/test_metrics.py

@@ -19,17 +19,14 @@
 # with Crate these terms will supersede the license and you may use the
 # software solely pursuant to the terms of the relevant commercial agreement.
 
-# mypy: disable-error-code="union-attr"
+# mypy: disable-error-code="attr-defined, arg-type, union-attr"
 
 import logging
 import time
 
 from prometheus_client import REGISTRY
 
-from crate.operator.prometheus import (  # type: ignore[attr-defined]
-    PrometheusClusterStatus,
-    report_cluster_status,
-)
+from crate.operator.prometheus import PrometheusClusterStatus, report_cluster_status
 
 logger = logging.getLogger(__name__)
 
@@ -52,15 +49,15 @@ def test_will_report_metrics_for_clusters():
     )
     cloud_clusters_last_seen = next(
         filter(
-            lambda s: s.labels["cluster_id"] == "id", cloud_clusters_last_seen.samples  # type: ignore[arg-type]  # noqa: E501
+            lambda s: s.labels["cluster_id"] == "id", cloud_clusters_last_seen.samples
         ),
         None,
     )
-    assert cloud_clusters_health_sample.value == 0  # type: ignore[attr-defined]  # noqa: E501
-    assert cloud_clusters_last_seen.value == last_reported  # type: ignore[attr-defined]  # noqa: E501
-    assert cloud_clusters_health_sample.labels["exported_namespace"] == "ns1"  # type: ignore[attr-defined]  # noqa: E501
-    assert cloud_clusters_last_seen.labels["exported_namespace"] == "ns1"  # type: ignore[attr-defined]  # noqa: E501
-    assert cloud_clusters_last_seen.labels["cluster_name"] == "cluster-name"  # type: ignore[attr-defined]  # noqa: E501
+    assert cloud_clusters_health_sample.value == 0
+    assert cloud_clusters_last_seen.value == last_reported
+    assert cloud_clusters_health_sample.labels["exported_namespace"] == "ns1"
+    assert cloud_clusters_last_seen.labels["exported_namespace"] == "ns1"
+    assert cloud_clusters_last_seen.labels["cluster_name"] == "cluster-name"
 
 
 def test_will_expire_clusters_that_have_not_reported_for_a_while():