IO: Implement suggestions by CodeRabbit

Author: amotl

cratedb_toolkit/cluster/core.py

@@ -529,7 +529,7 @@ def query(self, sql: str):
     def load_table(
         self,
         source: InputOutputResource,
-        target: t.Optional[TableAddress] = None,
+        target: TableAddress,
         transformation: t.Union[Path, None] = None,
     ) -> "StandaloneCluster":
         """

cratedb_toolkit/io/cratedb/cloud/model.py

@@ -73,5 +73,5 @@ class CloudIoSpecs:
     Define capabilities of CrateDB Cloud Import.
     """
 
-    allowed_compressions = ["gzip", None]
-    allowed_formats = ["csv", "json", "parquet"]
+    allowed_compressions: t.ClassVar[tuple] = ("gzip", None)
+    allowed_formats: t.ClassVar[tuple] = ("csv", "json", "parquet")

cratedb_toolkit/io/router.py

@@ -29,7 +29,7 @@ def load_table(
         source: InputOutputResource,
         target: DatabaseAddress,
         transformation: t.Union[Path, None] = None,
-    ):
+    ) -> bool:
         """
         Load data into unmanaged CrateDB cluster.
 
@@ -123,7 +123,7 @@ def save_table(
         source: DatabaseAddress,
         target: InputOutputResource,
         transformation: t.Union[Path, None] = None,
-    ):
+    ) -> bool:
         """
         Export data from a database table on a standalone CrateDB Server.
 
@@ -147,11 +147,15 @@ def save_table(
             if not to_deltalake(source_url, target.url):
                 raise OperationFailed("Data export failed or incomplete")
 
+            return True
+
         elif target_url_obj.scheme.startswith("iceberg") or target_url_obj.scheme.endswith("iceberg"):
             from cratedb_toolkit.io.iceberg import to_iceberg
 
             if not to_iceberg(source_url, target.url):
                 raise OperationFailed("Data export failed or incomplete")
 
+            return True
+
         else:
             raise OperationFailed(f"Exporting resource not implemented yet: {target_url_obj}")