IO: Implement suggestions by CodeRabbit

Author: amotl

cratedb_toolkit/io/kinesis/api.py

@@ -24,3 +24,5 @@ def kinesis_relay(source_url: URL, target_url: str, recipe: TransformationType =
 
     ka = KinesisRelay(str(source_url), target_url, recipe=parsed_recipe)
     ka.start(once=once)
+
+    return True

cratedb_toolkit/io/router.py

@@ -139,7 +139,10 @@ def save_table(
         """
         source_url = source.dburi
         target_url_obj = URL(target.url)
-        _ = transformation  # reserved by contract
+
+        # Note: The `transformation` parameter is not respected yet, but required by contract.
+        if transformation is not None:
+            raise OperationFailed("Export transformations are not supported yet")
 
         if target_url_obj.scheme.startswith("deltalake") or target_url_obj.scheme.endswith("deltalake"):
             from cratedb_toolkit.io.deltalake import to_deltalake

examples/cdc/aws/kinesis_put.py

@@ -9,6 +9,8 @@
 def main():
 
     # Address of the Kinesis stream.
+    # Note: Credentials and region are suitable for use with LocalStack ootb.
+    # It is acceptable for local development examples, so please adjust when diverting to streams on AWS.
     kinesis_url = URL("kinesis://LSIAQAAAAAAVNCBMPNSG:dummy@localhost:4566/cdc-stream?region=eu-central-1")
 
     # DynamoDB CDC data payload example.

tests/cluster/test_import.py

@@ -9,7 +9,7 @@
 @pytest.mark.skipif(
     os.getenv("FORCE", "no") != "yes",
     reason="Only works when invoked exclusively, using "
-    "`FORCE=yes pytest --no-cov tests/io/test_import.py -k managed_csv_local`. "
+    "`FORCE=yes pytest --no-cov tests/cluster/test_import.py -k test_csv_import_local`. "
     "Otherwise croaks per `AssertionError: ERROR: The following arguments are required: --url`. "
     "We don't know why.",
 )