Skip to content

ACK should generate reference and selector fields #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muvaf opened this issue Jan 6, 2021 · 3 comments
Closed

ACK should generate reference and selector fields #484

muvaf opened this issue Jan 6, 2021 · 3 comments
Assignees
Labels
ack Issues directly related to aws-controllers-k8s enhancement New feature or request

Comments

@muvaf
Copy link
Member

muvaf commented Jan 6, 2021

What problem are you facing?

ACK does not generate reference and selector fields. It adds a Custom{CRDName}Parameters field as inline and expects you to create that struct and add your ref & selector fields. This causes generated code not to compile as is and also requires developer to write Custom{CRDName}Parameters struct even if it's actually empty.

How could Crossplane help solve your problem?

ACK can actually add those fields, however, it needs to know which fields are reference-able. So, developer input will be needed to list which fields should have two additional fields as referencer and selector. After that, we'll likely not need Custom{CRDName}Parameters anymore and it can be deleted, which gets the generated code into compile-able state.

@haarchri
Copy link
Member

@muvaf is this topic solved with crossplane/crossplane-tools#35 ?

@muvaf
Copy link
Member Author

muvaf commented Dec 8, 2021

@haarchri No, that PR only generates the resolver function if the fields are marked. aws-controllers-k8s/code-generator#246 should help us mark the fields and then have the pipeline generate the rest.

@luebken luebken added the ack Issues directly related to aws-controllers-k8s label Dec 15, 2021
@haarchri
Copy link
Member

@muvaf ACK PR is merged

@haarchri haarchri closed this as completed Oct 2, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
Bump fkirc/skip-duplicate-actions Github action to v5.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Issues directly related to aws-controllers-k8s enhancement New feature or request
Projects
None yet
3 participants