-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Labels
code-qualitygood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededon holdThis issue was marked as not desirable to complete for nowThis issue was marked as not desirable to complete for nowvery-low-priority
Description
Found when I was tinkering with custom tests. We can use require()
-alike functions for specific tests, e.g., related to the fs operations, where a test case should not proceed.
For example, here:
https://github.com/trailofbits/medusa/blob/69fa1587de6e42e382a835f40316c4ec8382e8f4/utils/testutils/test_directory_utils.go#L21-L22
When a file (sourcePathInfo
) does not exist, a test case continues and panics here:
https://github.com/trailofbits/medusa/blob/69fa1587de6e42e382a835f40316c4ec8382e8f4/utils/testutils/test_directory_utils.go#L26-L26
just replace it with the require.NotNil(t, sourcePathInfo)
, and so on.
Xenomega
Metadata
Metadata
Assignees
Labels
code-qualitygood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededon holdThis issue was marked as not desirable to complete for nowThis issue was marked as not desirable to complete for nowvery-low-priority