Skip to content

Commit 82dbd51

Browse files
committed
Use v4 UUID instead of v1 for action IDs
This uses a purely random v4 UUID instead of a time-based v1 UUID for the action IDs (which were introduced in storybookjs#1347). v1 UUID are based on current time and the hardware MAC address of the machine where they are being generated (although the implementation in the npm uuid module uses generates a random fake MAC address). As such they have much more complex semantics than v4 UUIDs which are simply randomly generated. Unless there's a specific requirement for the special semantics of v1 UUIDs it is simpler and less error prone to simply go for v4 UUIDs whenever just a unique identifier is needed.
1 parent b82173b commit 82dbd51

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

addons/actions/src/preview/action.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import uuid from 'uuid/v1';
1+
import uuid from 'uuid/v4';
22
import { addons } from '@storybook/addons';
33
import { EVENT_ID } from '../constants';
44
import { ActionDisplay, ActionOptions, HandlerFunction } from '../models';

0 commit comments

Comments
 (0)