Skip to content

Commit 2fc9cb3

Browse files
authored
Merge pull request #996 from ctripcorp/bugfix/full_offset_begin
fix bug for unit test
2 parents eef9aa1 + 94e330c commit 2fc9cb3

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

redis/redis-keeper/src/main/java/com/ctrip/xpipe/redis/keeper/handler/keeper/GapAllowSyncHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ protected SyncAction anaRequest(SyncRequest request, RedisKeeperServer redisKeep
135135
XSyncContinue xsyncCont = null;
136136
if (request.proto == ReplStage.ReplProto.PSYNC) {
137137
if(request.offset < preStage.getBegOffsetRepl()) {
138-
SyncAction.full("request offset < beginOffsetRepl");
138+
return SyncAction.full("request offset < beginOffsetRepl");
139139
}
140140
reqBacklogOffset = preStage.replOffset2BacklogOffset(request.offset);
141141
} else {

redis/redis-keeper/src/test/java/com/ctrip/xpipe/redis/keeper/handler/keeper/GapAllowSyncHandlerTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,18 @@ public void testKeeperPartialSync_xcontinue() throws Exception {
232232
Assert.assertEquals(990, action.replOffset);
233233
}
234234

235+
@Test
236+
public void testKeeperOffsetVerySmaller() throws Exception {
237+
GapAllowSyncHandler.SyncRequest request = GapAllowSyncHandler.SyncRequest.psync("test-repl-id2", 1);
238+
ReplStage curStage = new ReplStage("test-repl-id", 1, 1001, "test-master-uuid", new GtidSet("A:1-10"), new GtidSet("A:1-20"));
239+
ReplStage preStage = new ReplStage("test-repl-id2", 100, 1);
240+
Mockito.when(keeperRepl.currentStage()).thenReturn(curStage);
241+
Mockito.when(keeperRepl.preStage()).thenReturn(preStage);
242+
243+
GapAllowSyncHandler.SyncAction action = handler.anaRequest(request, keeperServer, slave);
244+
Assert.assertTrue(action.full);
245+
}
246+
235247
@Test
236248
public void testKeeperPartialSync_continue() throws Exception {
237249
ReplStage replStage = new ReplStage("test-repl-id1", 1, 11);

0 commit comments

Comments
 (0)