Skip to content

Commit 2d0b693

Browse files
committed
Build as shared library on CI
Because this will catch errors with APIs not being properly marked for export. AFAIK this shouldn't fail to catch any errors that a static build would, so I'm not retaining the static build.
1 parent ae35d03 commit 2d0b693

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,8 @@ else()
317317
${ARGN}
318318
${CUKE_FEATURES_DIR}
319319
${USES_TERMINAL}
320+
# Execute in same directory as where DLLs appear on Windows
321+
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/src
320322
)
321323
endfunction(add_feature_target)
322324

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ install:
4141

4242
build_script:
4343
- cmake -E make_directory build
44-
- cmake -E chdir build cmake -G "%CMAKE_GENERATOR%" -DCUKE_ENABLE_EXAMPLES=ON -DBOOST_ROOT="%BOOST_ROOT%" -DBOOST_INCLUDEDIR="%BOOST_INCLUDEDIR%" -DBOOST_LIBRARYDIR="%BOOST_LIBRARYDIR%" -DCMAKE_PREFIX_PATH="%QT_DIR%" ..
44+
- cmake -E chdir build cmake -G "%CMAKE_GENERATOR%" -DCUKE_ENABLE_EXAMPLES=ON -DBUILD_SHARED_LIBS=ON -DBOOST_ROOT="%BOOST_ROOT%" -DBOOST_INCLUDEDIR="%BOOST_INCLUDEDIR%" -DBOOST_LIBRARYDIR="%BOOST_LIBRARYDIR%" -DCMAKE_PREFIX_PATH="%QT_DIR%" ..
4545
- cmake --build build
4646

4747
test_script:

travis.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ cmake -E make_directory build
5757
cmake -E chdir build cmake \
5858
-G Ninja \
5959
-DCUKE_ENABLE_EXAMPLES=on \
60+
-DBUILD_SHARED_LIBS=ON \
6061
${CMAKE_PREFIX_PATH:+"-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}"} \
6162
${COVERALLS_SERVICE_NAME:+"-DCMAKE_BUILD_TYPE=Debug"} \
6263
${COVERALLS_SERVICE_NAME:+"-DCMAKE_CXX_FLAGS='--coverage'"} \

0 commit comments

Comments
 (0)