Skip to content

Parameters in step macro instead of REGEX_PARAM #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paoloambrosio opened this issue Mar 26, 2016 · 2 comments
Closed

Parameters in step macro instead of REGEX_PARAM #112

paoloambrosio opened this issue Mar 26, 2016 · 2 comments
Assignees
Milestone

Comments

@paoloambrosio
Copy link
Member

Transform...

GIVEN("^I have entered (\\d+) into the calculator$") {
    REGEX_PARAM(double, n);
    ScenarioScope<CalcCtx> context;

    context->calc.push(n);
}

...into

GIVEN("^I have entered (\\d+) into the calculator$", double n) {
    ScenarioScope<CalcCtx> context;

    context->calc.push(n);
}
@konserw
Copy link
Contributor

konserw commented Aug 17, 2017

@muggenhor - maybe you should assign this one to yourself as I believe you are working on this issue in PR #159

BTW: Have you or @paoloambrosio considered using "projects" feature of github? I've never used it, but seems to be good way of organising work :)

@muggenhor muggenhor assigned muggenhor and unassigned paoloambrosio Aug 17, 2017
@muggenhor muggenhor modified the milestones: v0.5, Backlog Aug 17, 2017
@muggenhor
Copy link
Contributor

@konserw thanks for pointing this out.

And no, I haven't considered using the 'projects' feature. I'm not sure that will become usable until we're actually dealing with a large flood of issues or PRs, and this is the kind of project that shouldn't see those (because it's scope is pretty limited).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants