feat(api): update user profile on successfully agreing to terms and conditions

Author: HasithDeAlwis

apps/portal/app/routes/terms.tsx

@@ -1,53 +1,41 @@
 import type { LoaderData } from '@cuhacking/portal/types/legal'
-import type { LoaderFunction } from '@remix-run/node'
-import { userFlowActor } from '@/engine/actors/user'
+import type { ActionFunction, LoaderFunction } from '@remix-run/node'
 import { getLegalData } from '@cuhacking/portal/features/legal/api/data'
+import { updateTerms } from '@cuhacking/portal/features/legal/api/update-terms'
 import { getCurrentUser } from '@cuhacking/portal/features/profile/api/user'
 import { LegalPage } from '@cuhacking/portal/pages/legal'
 import { json, redirect } from '@remix-run/node'
 import { useLoaderData } from '@remix-run/react'
+import { getSession } from '../sessions'
 
-/* export const loader: LoaderFunction = async () => {
-*   const currentState = userFlowActor.getSnapshot()?.value
-*
-*   switch (currentState) {
-*     case 'unauthenticated':
-*       return redirect('/login')
-*     case 'legal':
-*       return redirect('/terms')
-*     case 'profile_incomplete':
-*       return redirect('/profile')
-*     case 'dashboard':
-*     case 'registered':
-*       return null
-*     default:
-*       return redirect('/login')
-*   }
-* } */
-
-export function action() {
-  try {
-    /* setIsLoading(true) */
-    userFlowActor.send({ type: 'TERM_SUCCESS' })
+export const loader: LoaderFunction = async ({ request }) => {
+  const cookie = request.headers.get('Cookie')
+  const { legalData } = getLegalData()
+  const user = await getCurrentUser({ cookie })
 
-    return redirect('/profile')
-  }
-  catch (error) {
-    console.error('Login failed:', error)
-  }
-  finally {
-    /* setIsLoading(false) */
+  if (!user) {
+    return redirect('/login')
   }
+
+  /* if (user?.agreedToTerms) {
+*   return redirect('/profile')
+* } */
+
+  return json<LoaderData>({ legalData, cookie })
 }
 
-export const loader: LoaderFunction = async () => {
-  const { legalData } = getLegalData()
-  const user = getCurrentUser()
-  return json<LoaderData>({ legalData, user })
+export const action: ActionFunction = async ({ request }) => {
+  const cookie = request.headers.get('Cookie')
+  const session = await getSession(cookie)
+  const userId = session.get('userId')
+
+  if (!userId) {
+    return redirect('/login')
+  }
+  return await updateTerms(userId, cookie)
 }
 
 export default function Index() {
-  const { legalData, user } = useLoaderData<LoaderData>()
-
-  return <LegalPage legalData={legalData} user={user} />
+  const { legalData } = useLoaderData<LoaderData>()
+  return <LegalPage legalData={legalData} />
 }

libs/portal/features/legal/api/update-terms.ts

@@ -0,0 +1,35 @@
+import process from 'node:process'
+import { json, redirect } from '@remix-run/node'
+
+const API_URL = `${process.env.NODE_ENV === 'development' ? process.env.CUHACKING_2025_AXIOM_LOCAL_URL : process.env.CUHACKING_2025_AXIOM_PUBLIC_URL}`
+export async function updateTerms(userId: string, cookie: string | null) {
+  try {
+    const response = await fetch(`${API_URL}/api/users/${userId}`, {
+      method: 'PATCH',
+      headers: {
+        'Content-Type': 'application/json',
+        'Cookie': cookie || '',
+      },
+      body: JSON.stringify({ agreedToTerms: true }),
+    })
+
+    if (!response.ok) {
+      return json(
+        { error: 'Failed to update user terms' },
+        { status: response.status },
+      )
+    }
+
+    return redirect('/profile')
+  }
+  catch (error) {
+    // Log the error for debugging purposes
+    console.error('Error updating user terms:', error)
+
+    // Return a generic error response
+    return json(
+      { error: 'An unexpected error occurred' },
+      { status: 500 },
+    )
+  }
+}

libs/portal/features/legal/ui/terms.tsx

@@ -143,10 +143,9 @@ export function Legal({ legalData }: LegalPageProps) {
       </Accordion>
 
       <div className="px-4 flex justify-center pb-6">
-        <Form method="post">
+        <Form method="patch">
           <Button
-            onClick={() => { }}
-            disabled={!allChecked || !allScrolled}
+            disabled={false}
             variant="secondary"
             aria-label="Redirect to Profile"
             type="submit"
@@ -158,7 +157,7 @@ export function Legal({ legalData }: LegalPageProps) {
               },
             )}
           >
-            <Typography variant="h6">LET'S CREATE YOUR PROFILE</Typography>
+            <Typography variant="h6"><span>LET'S CREATE YOUR PROFILE</span></Typography>
           </Button>
         </Form>
 

libs/portal/pages/legal/index.tsx

@@ -2,10 +2,10 @@ import type { LegalPageProps } from '@cuhacking/portal/types/terms'
 import { Legal } from '@cuhacking/portal/features/legal'
 import { Layout } from '@cuhacking/portal/ui/layout'
 
-export function LegalPage({ legalData, user }: LegalPageProps) {
+export function LegalPage({ legalData }: LegalPageProps) {
   return (
-    <Layout user={user}>
-      <Legal legalData={legalData} user={user} />
+    <Layout>
+      <Legal legalData={legalData} />
     </Layout>
   )
 }

libs/portal/types/terms.ts

@@ -15,5 +15,4 @@ export interface LoaderData {
 }
 export interface LegalPageProps {
   legalData: LegalItem[]
-  user: User
 }