Decorations don't scale with editor zoom

[brxck]

I'm on 5271ce3 and Ubuntu 20.10.

VS Code info:

Version: 1.57.1
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:26:56.255Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Linux x64 5.8.0-59-generic

No Zoom

5x Zoom

[brxck]

This is the case on my new machine as well 😢 Ubuntu 21.04.

[pokey]

Weird! I believe that zoom level is a setting, so we could maybe read zoom level and adjust based on that.

Strange that it only happens for some VSCode setups. Does it happen on a clean VSCode instance with no extensions installed?

We could have a setting to toggle this correction and then mention it in known issues

[pokey]

@brxck when you get a minute, would be amazing if you could check whether #273 fixes this one

[brxck]

@pokey unfortunately not 😦

[AndreasArvidsson]

@brxck Is this still a problem?

[brxck]

Yep, same behavior. Let me know if I can provide any other info/help!

[AndreasArvidsson]

This is so strange. We have tested this on the windows, linux, and mac and it works on all three except for on your computer.

[brxck]

Well I just realized something about this! Come to find out that there are two types of zoom actions in vscode.

workbench.action.zoomIn scales all UI. Cursorless deals with this as expected.

editor.action.fontZoomIn scales only the editor font. This will trigger the issue. These actions don't have any keybindings by default, but they are triggered on ctrl + mousewheel over the editor.

[pokey]

ohh weird. and that's different from increasing the font size?

[brxck]

Yep! Cursorless responds fine to font size changes. And apparently mousewheel zoom is a setting that is off by default? Don't remember turning that on... No wonder I'm the only person who's run into this 😅

[pokey]

Hmm. I wonder if we should fix this one or just add a note to https://github.com/cursorless-dev/cursorless-vscode/wiki/Troubleshooting

[brxck]

Hardly seems worth fixing at this point. Especially after a brief poke around the extension API didn't yield an obvious way to get at this zoom level.

[pokey]

Ok added https://github.com/cursorless-dev/cursorless-vscode/wiki/Troubleshooting#decorations-dont-scale-with-editor-zoom. Thanks for getting to the bottom of this one!