Properly calculate range when inserting new lines into CRLF documents (#1561)

Fixes #1542

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

Author: AndreasArvidsson

packages/common/src/types/TextDocument.ts

@@ -1,5 +1,5 @@
-import type { Position, Range, TextLine } from "..";
 import type { URI } from "vscode-uri";
+import type { EndOfLine, Position, Range, TextLine } from "..";
 
 export interface TextDocument {
   /**
@@ -31,6 +31,12 @@ export interface TextDocument {
    */
   readonly range: Range;
 
+  /**
+   * The {@link EndOfLine end of line} sequence that is predominately
+   * used in this document.
+   */
+  readonly eol: EndOfLine;
+
   /**
    * Returns a text line denoted by the line number. Note
    * that the returned object is *not* live and changes to the

packages/cursorless-engine/src/processTargets/targets/PositionTarget.ts

@@ -125,7 +125,7 @@ export default class PositionTarget extends BaseTarget<PositionTargetParameters>
     const startIndex = this.isBefore
       ? baseStartOffset + this.indentationString.length
       : baseStartOffset +
-        this.insertionDelimiter.length +
+        this.getLengthOfInsertionDelimiter() +
         this.indentationString.length;
 
     const endIndex = startIndex + text.length;
@@ -135,6 +135,19 @@ export default class PositionTarget extends BaseTarget<PositionTargetParameters>
       this.editor.document.positionAt(endIndex),
     );
   }
+
+  private getLengthOfInsertionDelimiter(): number {
+    // Went inserting a new line with eol `CRLF` each `\n` will be converted to
+    // `\r\n` and therefore the length is doubled.
+    if (this.editor.document.eol === "CRLF") {
+      // This function is only called when inserting after a range. Therefore we
+      // only care about leading new lines in the insertion delimiter.
+      const match = this.insertionDelimiter.match(/^\n+/);
+      const nlCount = match?.[0].length ?? 0;
+      return this.insertionDelimiter.length + nlCount;
+    }
+    return this.insertionDelimiter.length;
+  }
 }
 
 export function removalUnsupportedForPosition(position: string): Range {

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/chuckVestLFCR.yml renamed to packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/chuckVestCRLF.yml

@@ -0,0 +1,22 @@
+languageId: plaintext
+command:
+  version: 5
+  spokenForm: pour block
+  action: {name: editNewLineAfter}
+  targets:
+    - type: primitive
+      modifiers:
+        - type: containingScope
+          scopeType: {type: paragraph}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: "\r\n    foo"
+  selections:
+    - anchor: {line: 1, character: 4}
+      active: {line: 1, character: 4}
+  marks: {}
+finalState:
+  documentContents: "\r\n    foo\r\n\r\n    "
+  selections:
+    - anchor: {line: 3, character: 4}
+      active: {line: 3, character: 4}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/clearCoreFileLFCR.yml renamed to packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/clearCoreFileCRLF.yml

@@ -0,0 +1,22 @@
+languageId: plaintext
+command:
+  version: 5
+  spokenForm: pour item
+  action: {name: editNewLineAfter}
+  targets:
+    - type: primitive
+      modifiers:
+        - type: containingScope
+          scopeType: {type: collectionItem}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: "[\r\n    111,\r\n    222\r\n]"
+  selections:
+    - anchor: {line: 1, character: 4}
+      active: {line: 1, character: 4}
+  marks: {}
+finalState:
+  documentContents: "[\r\n    111,\r\n    ,\r\n    222\r\n]"
+  selections:
+    - anchor: {line: 2, character: 4}
+      active: {line: 2, character: 4}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/dropVestLFCR.yml renamed to packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/dropVestCRLF.yml

@@ -0,0 +1,22 @@
+languageId: python
+command:
+  version: 5
+  spokenForm: pour state
+  action: {name: editNewLineAfter}
+  targets:
+    - type: primitive
+      modifiers:
+        - type: containingScope
+          scopeType: {type: statement}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: "def whatever():\r\n    if True:\r\n        pass"
+  selections:
+    - anchor: {line: 1, character: 4}
+      active: {line: 1, character: 4}
+  marks: {}
+finalState:
+  documentContents: "def whatever():\r\n    if True:\r\n        pass\r\n    "
+  selections:
+    - anchor: {line: 3, character: 4}
+      active: {line: 3, character: 4}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/lineEndings/pourBlockCRLF.yml

@@ -1,5 +1,12 @@
-import { Position, Range, TextDocument, TextLine } from "@cursorless/common";
 import {
+  EndOfLine,
+  Position,
+  Range,
+  TextDocument,
+  TextLine,
+} from "@cursorless/common";
+import {
+  fromVscodeEndOfLine,
   fromVscodePosition,
   toVscodePosition,
   toVscodeRange,
@@ -30,6 +37,10 @@ export class VscodeTextDocumentImpl implements TextDocument {
     return new Range(0, 0, end.line, end.character);
   }
 
+  get eol(): EndOfLine {
+    return fromVscodeEndOfLine(this.document.eol);
+  }
+
   constructor(private document: vscode.TextDocument) {}
 
   public lineAt(lineOrPosition: number | Position): TextLine {