Support rich object to snippet action

Author: pokey

cursorless-talon/src/actions/wrap.py

@@ -1,5 +1,5 @@
 from dataclasses import dataclass
-from typing import Literal
+from typing import Literal, Union
 
 from talon import Module, actions
 
@@ -9,7 +9,7 @@
 @dataclass
 class Wrapper:
     type: Literal["pairedDelimiter", "snippet"]
-    extra_args: list[str]
+    extra_args: list[Union[str, dict]]
 
 
 mod = Module()
@@ -30,7 +30,27 @@ def cursorless_wrapper(m) -> Wrapper:
             extra_args=[paired_delimiter_info.left, paired_delimiter_info.right],
         )
     except AttributeError:
-        return Wrapper(type="snippet", extra_args=[m.cursorless_wrapper_snippet])
+        snippet_name, placeholder_name = parse_snippet_location(
+            m.cursorless_wrapper_snippet
+        )
+        return Wrapper(
+            type="snippet",
+            extra_args=[
+                {
+                    "type": "named",
+                    "name": snippet_name,
+                    "variableName": placeholder_name,
+                }
+            ],
+        )
+
+
+# here is the above function in python:
+def parse_snippet_location(snippet_location: str) -> tuple[str, str]:
+    [snippet_name, placeholder_name] = snippet_location.split(".")
+    if snippet_name is None or placeholder_name is None:
+        raise Exception("Snippet location missing '.'")
+    return (snippet_name, placeholder_name)
 
 
 # Maps from (action_type, wrapper_type) to action name

cursorless-talon/src/command.py

@@ -12,7 +12,7 @@
 mod = Module()
 
 CURSORLESS_COMMAND_ID = "cursorless.command"
-CURSORLESS_COMMAND_VERSION = 4
+CURSORLESS_COMMAND_VERSION = 5
 last_phrase = None
 
 

cursorless-talon/src/cursorless_snippets.talon

@@ -8,4 +8,4 @@ tag: user.cursorless
     user.cursorless_single_target_command(cursorless_insert_snippet_action, cursorless_positional_target, cursorless_insertion_snippet)
 
 {user.cursorless_insert_snippet_action} {user.cursorless_insertion_snippet_single_phrase} <user.text> [{user.cursorless_phrase_terminator}]:
-    user.cursorless_insert_snippet_with_phrase(cursorless_insert_snippet_action, cursorless_insertion_snippet_single_phrase, text)
+    user.private_cursorless_insert_snippet_with_phrase(cursorless_insert_snippet_action, cursorless_insertion_snippet_single_phrase, text)

cursorless-talon/src/snippets.py

@@ -1,3 +1,5 @@
+from typing import Any, Optional
+
 from talon import Module, actions, app
 
 from .csv_overrides import init_csv_and_watch_changes
@@ -65,7 +67,7 @@ def cursorless_insertion_snippet(m) -> str:
 
 @mod.action_class
 class Actions:
-    def cursorless_insert_snippet_with_phrase(
+    def private_cursorless_insert_snippet_with_phrase(
         action: str, snippet_description: str, text: str
     ):
         """Perform cursorless wrap action"""
@@ -74,6 +76,51 @@ def cursorless_insert_snippet_with_phrase(
             action, snippet_name, {snippet_variable: text}
         )
 
+    def cursorless_insert_named_snippet(name: str, target: Optional[dict] = None):
+        """Inserts a named snippet"""
+
+    def cursorless_insert_custom_snippet(
+        body: str, target: Optional[dict] = None, scope: Optional[str] = None
+    ):
+        """Inserts a custom snippet"""
+        # Note that we convert scope to a proper scopeType; technically it is a scopeTypeType
+
+    def cursorless_wrap_with_named_snippet(name: str, variable_name: str, target: dict):
+        """Wrap target with a named snippet"""
+        actions.user.cursorless_single_target_command_with_arg_list(
+            "wrapWithSnippet",
+            target,
+            [
+                {
+                    "type": "named",
+                    "name": name,
+                    "variableName": variable_name,
+                }
+            ],
+        )
+
+    def cursorless_wrap_with_custom_snippet(
+        body: str,
+        target: dict,
+        variable_name: Optional[str] = None,
+        scope: Optional[str] = None,
+    ):
+        """Wrap target with a custom snippet"""
+        snippet_arg: dict[str, Any] = {
+            "type": "custom",
+            "body": body,
+        }
+        if scope is not None:
+            snippet_arg["scopeType"] = {"type": scope}
+        if variable_name is not None:
+            snippet_arg["variableName"] = variable_name
+
+        actions.user.cursorless_single_target_command_with_arg_list(
+            "wrapWithSnippet",
+            target,
+            [snippet_arg],
+        )
+
 
 def on_ready():
     init_csv_and_watch_changes(

packages/common/src/index.ts

@@ -69,8 +69,9 @@ export * from "./types/command/ActionCommand";
 export * from "./types/command/legacy/CommandV0V1.types";
 export * from "./types/command/legacy/CommandV2.types";
 export * from "./types/command/legacy/CommandV3.types";
+export * from "./types/command/legacy/CommandV4.types";
 export * from "./types/command/legacy/targetDescriptorV2.types";
-export * from "./types/command/CommandV4.types";
+export * from "./types/command/CommandV5.types";
 export * from "./types/command/legacy/PartialTargetDescriptorV3.types";
 export * from "./types/CommandServerApi";
 export * from "./util/itertools";

packages/common/src/types/command/CommandV4.types.ts renamed to packages/common/src/types/command/CommandV5.types.ts

@@ -1,11 +1,11 @@
 import type { PartialTargetDescriptor } from "./PartialTargetDescriptor.types";
 import type { ActionCommand } from "./ActionCommand";
 
-export interface CommandV4 {
+export interface CommandV5 {
   /**
    * The version number of the command API
    */
-  version: 4;
+  version: 5;
 
   /**
    * The spoken form of the command if issued from a voice command system

packages/common/src/types/command/command.types.ts

@@ -1,16 +1,23 @@
 import type { ActionCommand } from "./ActionCommand";
+import type { CommandV5 } from "./CommandV5.types";
 import type { CommandV0, CommandV1 } from "./legacy/CommandV0V1.types";
 import type { CommandV2 } from "./legacy/CommandV2.types";
 import type { CommandV3 } from "./legacy/CommandV3.types";
-import type { CommandV4 } from "./CommandV4.types";
+import type { CommandV4 } from "./legacy/CommandV4.types";
 
 export type CommandComplete = Required<Omit<CommandLatest, "spokenForm">> &
   Pick<CommandLatest, "spokenForm"> & { action: Required<ActionCommand> };
 
-export const LATEST_VERSION = 4 as const;
+export const LATEST_VERSION = 5 as const;
 
 export type CommandLatest = Command & {
   version: typeof LATEST_VERSION;
 };
 
-export type Command = CommandV0 | CommandV1 | CommandV2 | CommandV3 | CommandV4;
+export type Command =
+  | CommandV0
+  | CommandV1
+  | CommandV2
+  | CommandV3
+  | CommandV4
+  | CommandV5;

packages/common/src/types/command/legacy/CommandV4.types.ts

@@ -0,0 +1,95 @@
+import { PartialTargetDescriptorV4 } from "./PartialTargetDescriptorV4.types";
+
+type ActionType =
+  | "callAsFunction"
+  | "clearAndSetSelection"
+  | "copyToClipboard"
+  | "cutToClipboard"
+  | "deselect"
+  | "editNew"
+  | "editNewLineAfter"
+  | "editNewLineBefore"
+  | "executeCommand"
+  | "extractVariable"
+  | "findInWorkspace"
+  | "foldRegion"
+  | "followLink"
+  | "generateSnippet"
+  | "getText"
+  | "highlight"
+  | "indentLine"
+  | "insertCopyAfter"
+  | "insertCopyBefore"
+  | "insertEmptyLineAfter"
+  | "insertEmptyLineBefore"
+  | "insertEmptyLinesAround"
+  | "insertSnippet"
+  | "moveToTarget"
+  | "outdentLine"
+  | "pasteFromClipboard"
+  | "randomizeTargets"
+  | "remove"
+  | "rename"
+  | "replace"
+  | "replaceWithTarget"
+  | "revealDefinition"
+  | "revealTypeDefinition"
+  | "reverseTargets"
+  | "rewrapWithPairedDelimiter"
+  | "scrollToBottom"
+  | "scrollToCenter"
+  | "scrollToTop"
+  | "setSelection"
+  | "setSelectionAfter"
+  | "setSelectionBefore"
+  | "showDebugHover"
+  | "showHover"
+  | "showQuickFix"
+  | "showReferences"
+  | "sortTargets"
+  | "swapTargets"
+  | "toggleLineBreakpoint"
+  | "toggleLineComment"
+  | "unfoldRegion"
+  | "wrapWithPairedDelimiter"
+  | "wrapWithSnippet";
+
+export interface ActionCommandV4 {
+  /**
+   * The action to run
+   */
+  name: ActionType;
+
+  /**
+   * A list of arguments expected by the given action.
+   */
+  args?: unknown[];
+}
+
+export interface CommandV4 {
+  /**
+   * The version number of the command API
+   */
+  version: 4;
+
+  /**
+   * The spoken form of the command if issued from a voice command system
+   */
+  spokenForm?: string;
+
+  /**
+   * If the command is issued from a voice command system, this boolean indicates
+   * whether we should use the pre phrase snapshot. Only set this to true if the
+   * voice command system issues a pre phrase signal at the start of every
+   * phrase.
+   */
+  usePrePhraseSnapshot: boolean;
+
+  action: ActionCommandV4;
+
+  /**
+   * A list of targets expected by the action. Inference will be run on the
+   * targets
+   */
+  targets: PartialTargetDescriptorV4[];
+}