Skip to content

"clone block" should insert empty line #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pokey opened this issue Aug 11, 2021 · 4 comments
Closed

"clone block" should insert empty line #213

pokey opened this issue Aug 11, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Aug 11, 2021 •
edited
Loading

I believe we'll get this one roughly for free from #210
@pokey pokey added the bug Something isn't working label Aug 11, 2021
@AndreasArvidsson
Copy link
Member

Well clone is defined as copyLinesDown. It has really no concept of selection/scope type.

@pokey
Copy link
Member Author

pokey commented Aug 13, 2021

Sure. But it seems like nice behaviour no? Tbh I'm tempted to generalise it and just call it cloneDown. Could see using it to clone args and whatnot. Then you'd expect it to inset a delimiter

@AndreasArvidsson
Copy link
Member

Yes it would be useful, but if won't use them for arguments and similar I should probably be copyAfter or cloneAfter

@AndreasArvidsson AndreasArvidsson self-assigned this Aug 15, 2021
@AndreasArvidsson AndreasArvidsson removed their assignment Oct 6, 2021
@pokey
Copy link
Member Author

pokey commented Jul 8, 2022

Fixed by #672

@pokey pokey closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pokey @AndreasArvidsson