Skip to content

cheat sheet should use imgui.scale setting #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasArvidsson opened this issue Dec 10, 2021 · 5 comments · Fixed by #619
Closed

cheat sheet should use imgui.scale setting #454

AndreasArvidsson opened this issue Dec 10, 2021 · 5 comments · Fixed by #619
Labels
documentation Improvements or additions to documentation talon Related to cursorless-talon

Comments

@AndreasArvidsson
Copy link
Member

I don't even know if it's possible to fetch a setting you haven't defined. But would be really useful for cursorless to use this one

@somanythings
Copy link

Yes, this is biting me at the moment.

Possibly related: It's super tiny on laptop 3k, but weirdly, on the bug external monitor, rather than larger and normal like i see with other talon windows, the font is larger, but the window is about the same physical size so I only see 1/4 of the content in the top left.

@pokey
Copy link
Member

pokey commented Dec 16, 2021

You can just use settings.get("imgui.scale"). Not sure where to apply this setting though?

@AndreasArvidsson
Copy link
Member Author

I just assume that you multiply width and height with it

@pokey
Copy link
Member

pokey commented Dec 16, 2021

Hmm. Not sure, because that won't scale the font, right? It would just add a bunch of padding, no? Maybe we could do a discord session with @somanythings to figure out what the right behaviour is here

@AndreasArvidsson
Copy link
Member Author

Fonts have height as well. You need to scale every component to make it work.

@pokey pokey transferred this issue from cursorless-dev/cursorless-talon Jan 12, 2022
@pokey pokey added documentation Improvements or additions to documentation talon Related to cursorless-talon labels Jan 12, 2022
@pokey pokey closed this as completed in #619 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation talon Related to cursorless-talon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants