Skip to content

Fix "head block line air" #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #193
pokey opened this issue Jun 26, 2022 · 0 comments · Fixed by #809
Closed
Tracked by #193

Fix "head block line air" #789

pokey opened this issue Jun 26, 2022 · 0 comments · Fixed by #809
Assignees
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Jun 26, 2022

We would expect this to select from the line containing air through the start of the block, but instead head eats block and line so instead goes from the token air through the start of the block

Keep in mind that we still need to support "head inside round", which is why currently "head" eats all modifiers until it hits the mark.

Potentially instead of having "head" eat every modifier, instead we should only eat first modify after "inside" or something like that. Put another way, "inside" binds very tightly to the thing that comes after it.

One way to handle this would be for "inside" to behave like "every" and just be a modifier that expects a scope type to be after it. In this case we would have to figure out how to make "take inside" and "take inside air" work. Also need to think about "take inside every funk"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants