Skip to content

Commit 1b70398

Browse files
P0lipP0lip
authored
fix(cli): peer dependency incorrectly met (stoplightio#2268)
1 parent b4c3c11 commit 1b70398

File tree

5 files changed

+25
-100
lines changed

5 files changed

+25
-100
lines changed

‎package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"@swc/jest": "^0.2.21",
7474
"@types/file-entry-cache": "^5.0.2",
7575
"@types/jest": "^28.1.6",
76-
"@types/jest-when": "^2.7.3",
7776
"@types/karma": "^6.3.3",
7877
"@types/lodash": "^4.14.176",
7978
"@types/node": "^15.12.4",
@@ -93,7 +92,6 @@
9392
"husky": "^7.0.4",
9493
"jest": "^28.1.3",
9594
"jest-mock": "^27.5.1",
96-
"jest-when": "^3.4.2",
9795
"karma": "^6.4.0",
9896
"karma-chrome-launcher": "^3.1.1",
9997
"karma-jasmine": "^5.1.0",

‎packages/cli/package.json

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,16 @@
3333
"release": "semantic-release -e semantic-release-monorepo"
3434
},
3535
"dependencies": {
36-
"@rollup/plugin-commonjs": "^20.0.0",
37-
"@stoplight/json": "3.17.0",
36+
"@stoplight/json": "~3.20.1",
3837
"@stoplight/path": "1.3.2",
39-
"@stoplight/spectral-core": "^1.5.1",
40-
"@stoplight/spectral-parsers": "^1.0.1",
38+
"@stoplight/spectral-core": "^1.15.1",
39+
"@stoplight/spectral-parsers": "^1.0.2",
4140
"@stoplight/spectral-ref-resolver": "1.0.2",
42-
"@stoplight/spectral-ruleset-bundler": "^1.0.0",
41+
"@stoplight/spectral-ruleset-bundler": "^1.4.0",
4342
"@stoplight/spectral-ruleset-migrator": "^1.9.0",
4443
"@stoplight/spectral-rulesets": ">=1",
45-
"@stoplight/spectral-runtime": "^1.1.0",
46-
"@stoplight/types": "12.3.0",
44+
"@stoplight/spectral-runtime": "^1.1.2",
45+
"@stoplight/types": "^13.6.0",
4746
"chalk": "4.1.2",
4847
"cliui": "7.0.4",
4948
"eol": "0.9.1",
@@ -63,7 +62,6 @@
6362
"@types/yargs": "^17.0.8",
6463
"copyfiles": "^2.4.1",
6564
"es-aggregate-error": "^1.0.7",
66-
"jest-when": "^3.4.2",
6765
"nock": "^13.1.3",
6866
"node-html-parser": "^4.1.5",
6967
"pkg": "^5.4.1",

‎packages/cli/src/services/linter/utils/__tests__/listFiles.test.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import * as path from '@stoplight/path';
22
import * as fg from 'fast-glob';
3-
import { when } from 'jest-when';
43
import { listFiles } from '../listFiles';
54

65
jest.mock('fast-glob', () => jest.fn(async () => []));
@@ -25,11 +24,13 @@ describe('listFiles CLI util', () => {
2524
it('given disabled ignoredUnmatchedGlobs, reports unmatched patterns', async () => {
2625
const list = [path.join(__dirname, 'foo/a.json'), path.join(__dirname, 'foo/b.json')];
2726

28-
when(fg as unknown as jest.Mock)
29-
.calledWith('./foo/*.json', expect.any(Object))
30-
.mockResolvedValueOnce([...list])
31-
.calledWith('bar/**/baz*.yaml', expect.any(Object))
32-
.mockResolvedValueOnce([]);
27+
(fg as unknown as jest.Mock).mockImplementation(async pattern => {
28+
if (pattern === './foo/*.json') {
29+
return list;
30+
}
31+
32+
return [];
33+
});
3334

3435
expect(await listFiles(['./foo/*.json', 'bar/**/baz*.yaml'], false)).toEqual([list, ['bar/**/baz*.yaml']]);
3536
});

‎packages/cli/src/services/linter/utils/getRuleset.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import { fetch } from '@stoplight/spectral-runtime';
88
import { migrateRuleset, isBasicRuleset } from '@stoplight/spectral-ruleset-migrator';
99
import { bundleRuleset } from '@stoplight/spectral-ruleset-bundler';
1010
import { node } from '@stoplight/spectral-ruleset-bundler/presets/node';
11+
import { commonjs } from '@stoplight/spectral-ruleset-bundler/plugins/commonjs';
1112
import { stdin } from '@stoplight/spectral-ruleset-bundler/plugins/stdin';
1213
import { builtins } from '@stoplight/spectral-ruleset-bundler/plugins/builtins';
1314
import { isError, isObject } from 'lodash';
14-
import commonjs from '@rollup/plugin-commonjs';
1515
import { CLIError } from '../../../errors';
1616

1717
async function getDefaultRulesetFile(): Promise<Optional<string>> {

‎yarn.lock

Lines changed: 11 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -2218,23 +2218,6 @@ __metadata:
22182218
languageName: node
22192219
linkType: hard
22202220

2221-
"@rollup/plugin-commonjs@npm:^20.0.0":
2222-
version: 20.0.0
2223-
resolution: "@rollup/plugin-commonjs@npm:20.0.0"
2224-
dependencies:
2225-
"@rollup/pluginutils": ^3.1.0
2226-
commondir: ^1.0.1
2227-
estree-walker: ^2.0.1
2228-
glob: ^7.1.6
2229-
is-reference: ^1.2.1
2230-
magic-string: ^0.25.7
2231-
resolve: ^1.17.0
2232-
peerDependencies:
2233-
rollup: ^2.38.3
2234-
checksum: fefc4b5ab1509ff64e26dfee3eca2f23cea204bf20f3dc76c616d3aa3faf4b1035166287518a64ba07faaaea1621a0af5b94b8f8199371ca67db905562e7e619
2235-
languageName: node
2236-
linkType: hard
2237-
22382221
"@rollup/plugin-commonjs@npm:~22.0.2":
22392222
version: 22.0.2
22402223
resolution: "@rollup/plugin-commonjs@npm:22.0.2"
@@ -2462,19 +2445,6 @@ __metadata:
24622445
languageName: node
24632446
linkType: hard
24642447

2465-
"@stoplight/json@npm:3.17.0":
2466-
version: 3.17.0
2467-
resolution: "@stoplight/json@npm:3.17.0"
2468-
dependencies:
2469-
"@stoplight/ordered-object-literal": ^1.0.2
2470-
"@stoplight/types": ^12.3.0
2471-
jsonc-parser: ~2.2.1
2472-
lodash: ^4.17.21
2473-
safe-stable-stringify: ^1.1
2474-
checksum: 452bb6963d35196420d1214320223c38d3c7858a0420ad222d347c6bcaf69a5897add288ae7305f6cf46ff1f078c037f4c9deb42911f8f0907bcfbd97dcfbd62
2475-
languageName: node
2476-
linkType: hard
2477-
24782448
"@stoplight/json@npm:^3.17.0, @stoplight/json@npm:^3.17.1, @stoplight/json@npm:^3.20.1, @stoplight/json@npm:~3.20.1":
24792449
version: 3.20.1
24802450
resolution: "@stoplight/json@npm:3.20.1"
@@ -2489,7 +2459,7 @@ __metadata:
24892459
languageName: node
24902460
linkType: hard
24912461

2492-
"@stoplight/ordered-object-literal@npm:^1.0.1, @stoplight/ordered-object-literal@npm:^1.0.2, @stoplight/ordered-object-literal@npm:^1.0.3, @stoplight/ordered-object-literal@npm:~1.0.4":
2462+
"@stoplight/ordered-object-literal@npm:^1.0.1, @stoplight/ordered-object-literal@npm:^1.0.3, @stoplight/ordered-object-literal@npm:~1.0.4":
24932463
version: 1.0.4
24942464
resolution: "@stoplight/ordered-object-literal@npm:1.0.4"
24952465
checksum: 81afa24943880b0a213af3728a9fe0a28bd01d4840b9583d448f7823ced5b6e673628698b59d201cef50afebcbd89256e133714a174968d11b624d943e0c2c2f
@@ -2507,17 +2477,16 @@ __metadata:
25072477
version: 0.0.0-use.local
25082478
resolution: "@stoplight/spectral-cli@workspace:packages/cli"
25092479
dependencies:
2510-
"@rollup/plugin-commonjs": ^20.0.0
2511-
"@stoplight/json": 3.17.0
2480+
"@stoplight/json": ~3.20.1
25122481
"@stoplight/path": 1.3.2
2513-
"@stoplight/spectral-core": ^1.5.1
2514-
"@stoplight/spectral-parsers": ^1.0.1
2482+
"@stoplight/spectral-core": ^1.15.1
2483+
"@stoplight/spectral-parsers": ^1.0.2
25152484
"@stoplight/spectral-ref-resolver": 1.0.2
2516-
"@stoplight/spectral-ruleset-bundler": ^1.0.0
2485+
"@stoplight/spectral-ruleset-bundler": ^1.4.0
25172486
"@stoplight/spectral-ruleset-migrator": ^1.9.0
25182487
"@stoplight/spectral-rulesets": ">=1"
2519-
"@stoplight/spectral-runtime": ^1.1.0
2520-
"@stoplight/types": 12.3.0
2488+
"@stoplight/spectral-runtime": ^1.1.2
2489+
"@stoplight/types": ^13.6.0
25212490
"@types/es-aggregate-error": ^1.0.2
25222491
"@types/xml2js": ^0.4.9
25232492
"@types/yargs": ^17.0.8
@@ -2527,7 +2496,6 @@ __metadata:
25272496
eol: 0.9.1
25282497
es-aggregate-error: ^1.0.7
25292498
fast-glob: 3.2.7
2530-
jest-when: ^3.4.2
25312499
lodash: ~4.17.21
25322500
nock: ^13.1.3
25332501
node-html-parser: ^4.1.5
@@ -2545,7 +2513,7 @@ __metadata:
25452513
languageName: unknown
25462514
linkType: soft
25472515

2548-
"@stoplight/spectral-core@*, @stoplight/spectral-core@>=1, @stoplight/spectral-core@^1.5.1, @stoplight/spectral-core@^1.7.0, @stoplight/spectral-core@^1.8.0, @stoplight/spectral-core@^1.8.1, @stoplight/spectral-core@workspace:packages/core":
2516+
"@stoplight/spectral-core@*, @stoplight/spectral-core@>=1, @stoplight/spectral-core@^1.15.1, @stoplight/spectral-core@^1.7.0, @stoplight/spectral-core@^1.8.0, @stoplight/spectral-core@^1.8.1, @stoplight/spectral-core@workspace:packages/core":
25492517
version: 0.0.0-use.local
25502518
resolution: "@stoplight/spectral-core@workspace:packages/core"
25512519
dependencies:
@@ -2610,7 +2578,7 @@ __metadata:
26102578
languageName: unknown
26112579
linkType: soft
26122580

2613-
"@stoplight/spectral-parsers@*, @stoplight/spectral-parsers@>=1, @stoplight/spectral-parsers@^1.0.1, @stoplight/spectral-parsers@workspace:packages/parsers":
2581+
"@stoplight/spectral-parsers@*, @stoplight/spectral-parsers@>=1, @stoplight/spectral-parsers@^1.0.2, @stoplight/spectral-parsers@workspace:packages/parsers":
26142582
version: 0.0.0-use.local
26152583
resolution: "@stoplight/spectral-parsers@workspace:packages/parsers"
26162584
dependencies:
@@ -2633,7 +2601,7 @@ __metadata:
26332601
languageName: unknown
26342602
linkType: soft
26352603

2636-
"@stoplight/spectral-ruleset-bundler@^1.0.0, @stoplight/spectral-ruleset-bundler@workspace:packages/ruleset-bundler":
2604+
"@stoplight/spectral-ruleset-bundler@^1.4.0, @stoplight/spectral-ruleset-bundler@workspace:packages/ruleset-bundler":
26372605
version: 0.0.0-use.local
26382606
resolution: "@stoplight/spectral-ruleset-bundler@workspace:packages/ruleset-bundler"
26392607
dependencies:
@@ -2726,26 +2694,6 @@ __metadata:
27262694
languageName: unknown
27272695
linkType: soft
27282696

2729-
"@stoplight/types@npm:12.3.0":
2730-
version: 12.3.0
2731-
resolution: "@stoplight/types@npm:12.3.0"
2732-
dependencies:
2733-
"@types/json-schema": ^7.0.4
2734-
utility-types: ^3.10.0
2735-
checksum: 28065540d2d30743bfaa4ab09df3dc1e2a216f14962f78e27d8e53eda7f293f64eba8703be53b8d179dff403f54764e0823baa578fa85f78280d21b0ae22e773
2736-
languageName: node
2737-
linkType: hard
2738-
2739-
"@stoplight/types@npm:^12.3.0":
2740-
version: 12.5.0
2741-
resolution: "@stoplight/types@npm:12.5.0"
2742-
dependencies:
2743-
"@types/json-schema": ^7.0.4
2744-
utility-types: ^3.10.0
2745-
checksum: fe4a09df6e1c2f0cdb53f474b180cc7b8184e814e1ac4427d199642f10958335f597060530a908c0e5800ba2569d077afe124a51deaee466255ce942e1e03941
2746-
languageName: node
2747-
linkType: hard
2748-
27492697
"@stoplight/types@npm:^12.3.0 || ^13.0.0, @stoplight/types@npm:^13.0.0, @stoplight/types@npm:^13.6.0":
27502698
version: 13.7.0
27512699
resolution: "@stoplight/types@npm:13.7.0"
@@ -3117,16 +3065,7 @@ __metadata:
31173065
languageName: node
31183066
linkType: hard
31193067

3120-
"@types/jest-when@npm:^2.7.3":
3121-
version: 2.7.4
3122-
resolution: "@types/jest-when@npm:2.7.4"
3123-
dependencies:
3124-
"@types/jest": "*"
3125-
checksum: fea5f5c9b882ee5191ef47dfbbe71ce7935d4ede7ac12c2bf7dbceead3da066930aa492fc534f8b53ef6694f30313b5669b87cb45e36ddbece42c6ff27b01364
3126-
languageName: node
3127-
linkType: hard
3128-
3129-
"@types/jest@npm:*, @types/jest@npm:^28.1.6":
3068+
"@types/jest@npm:^28.1.6":
31303069
version: 28.1.7
31313070
resolution: "@types/jest@npm:28.1.7"
31323071
dependencies:
@@ -8209,15 +8148,6 @@ __metadata:
82098148
languageName: node
82108149
linkType: hard
82118150

8212-
"jest-when@npm:^3.4.2":
8213-
version: 3.5.1
8214-
resolution: "jest-when@npm:3.5.1"
8215-
peerDependencies:
8216-
jest: ">= 25"
8217-
checksum: 1efb9f497f7c846fe8b0f4125d5f449c4a4d78d5d0afa910d134b301ae4c119ea52c9465db38d2146269d42808afe8f3a4328d1d656878a9a69458ee653f6499
8218-
languageName: node
8219-
linkType: hard
8220-
82218151
"jest-worker@npm:^28.1.3":
82228152
version: 28.1.3
82238153
resolution: "jest-worker@npm:28.1.3"
@@ -11547,7 +11477,6 @@ __metadata:
1154711477
"@swc/jest": ^0.2.21
1154811478
"@types/file-entry-cache": ^5.0.2
1154911479
"@types/jest": ^28.1.6
11550-
"@types/jest-when": ^2.7.3
1155111480
"@types/karma": ^6.3.3
1155211481
"@types/lodash": ^4.14.176
1155311482
"@types/node": ^15.12.4
@@ -11567,7 +11496,6 @@ __metadata:
1156711496
husky: ^7.0.4
1156811497
jest: ^28.1.3
1156911498
jest-mock: ^27.5.1
11570-
jest-when: ^3.4.2
1157111499
karma: ^6.4.0
1157211500
karma-chrome-launcher: ^3.1.1
1157311501
karma-jasmine: ^5.1.0

0 commit comments

Comments
 (0)