Merge pull request #731 from cypherstack/bch-p2sh

rehrar · web-flow · commit ad943ad8d674 · 2024-01-23T16:49:27.000-07:00
BCH: Do not validate "p" (P2SH) addresses.
diff --git a/lib/wallets/crypto_currency/coins/bitcoincash.dart b/lib/wallets/crypto_currency/coins/bitcoincash.dart
@@ -192,7 +192,8 @@ class Bitcoincash extends Bip39HDCurrency {
       addr = cashAddr.split(":").last;
     }
 
-    return addr.startsWith("q") || addr.startsWith("p");
+    return addr.startsWith("q") /*|| addr.startsWith("p")*/;
+    // Do not validate "p" (P2SH) addresses.
   }
 
   @override

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,8 @@ class Bitcoincash extends Bip39HDCurrency {`
`192`	`192`	`addr = cashAddr.split(":").last;`
`193`	`193`	`}`
`194`	`194`
`195`		`- return addr.startsWith("q") \|\| addr.startsWith("p");`
	`195`	`+ return addr.startsWith("q") /\|\| addr.startsWith("p")/;`
	`196`	`+ // Do not validate "p" (P2SH) addresses.`
`196`	`197`	`}`
`197`	`198`
`198`	`199`	`@override`