fix: poor outgoing network performance on Mac (#20062)

Author: moyara-twilio

packages/network/lib/connect.ts

@@ -11,7 +11,7 @@ export function byPortAndAddress (port: number, address: net.Address) {
   // https://nodejs.org/api/net.html#net_net_connect_port_host_connectlistener
   return new Bluebird<net.Address>((resolve, reject) => {
     const onConnect = () => {
-      client.end()
+      client.destroy()
       resolve(address)
     }
 

packages/network/test/unit/connect_spec.ts

@@ -0,0 +1,27 @@
+import { connect } from '../..'
+import { expect } from 'chai'
+import sinon from 'sinon'
+import net from 'net'
+
+describe('lib/connect', () => {
+  context('.byPortAndAddress', () => {
+    it('destroy connection immediately onConnect', () => {
+      const socket = new net.Socket()
+      const destroy = sinon.spy(socket, 'destroy')
+
+      sinon.stub(net, 'connect').callsFake((port, address, onConnect) => {
+        process.nextTick(() => {
+          onConnect()
+        })
+
+        return socket
+      })
+
+      return connect.byPortAndAddress(1234, { address: '127.0.0.1' })
+      .then((address) => {
+        expect(address).to.deep.eq({ address: '127.0.0.1' })
+        expect(destroy).to.be.called
+      })
+    })
+  })
+})