Use tuple comprehension for DataladMode choices

Copilot · yarikoptic · Copilot · commit 4eb69e5e0181 · 2026-02-13T20:25:27.000Z
- Change from list to tuple comprehension to avoid creating new list on each import
- More efficient and follows best practices

Co-authored-by: yarikoptic &lt;39889+yarikoptic@users.noreply.github.com&gt;
diff --git a/dandi/cli/cmd_upload.py b/dandi/cli/cmd_upload.py
@@ -50,7 +50,7 @@
 )
 @click.option(
     "--datalad",
-    type=click.Choice([e.value for e in DataladMode]),
+    type=click.Choice(tuple(e.value for e in DataladMode)),
     default="no",
     show_default=True,
     help=(

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@`
`50`	`50`	`)`
`51`	`51`	`@click.option(`
`52`	`52`	`"--datalad",`
`53`		`- type=click.Choice([e.value for e in DataladMode]),`
	`53`	`+ type=click.Choice(tuple(e.value for e in DataladMode)),`
`54`	`54`	`default="no",`
`55`	`55`	`show_default=True,`
`56`	`56`	`help=(`