Document test-support feature: why it exists and how to run full test suite

Clarify in CLAUDE.md, PROJECT.md, code-reviewer, and plan-reviewer
that make test/lint require --features test-support, that cfg(test)
does not apply when the library is built as a dep for integration
tests, and that plain cargo test skips integration tests.

Author: danielealbano

.claude/agents/code-reviewer.md

@@ -56,7 +56,7 @@ Review code changes across five dimensions: **QA**, **Architecture Compliance**,
 
 ### Testing Verification — MANDATORY
 
-- You MUST run `make test` to verify tests pass. You MUST flag ANY failure.
+- You MUST run `make test` to verify tests pass (runs `cargo test --features test-support`). Plain `cargo test` skips integration tests because `MockAzureDevOpsApi` is only generated when `test-support` is enabled. You MUST flag ANY failure.
 - You MUST verify tests exist for new/changed code: happy path, edge cases, failure modes. Flag missing tests as WARNING.
 - You MUST verify unit tests follow the project conventions:
   - `#[cfg(test)] mod tests` blocks within source files.
@@ -65,11 +65,12 @@ Review code changes across five dimensions: **QA**, **Architecture Compliance**,
   - `assert!`, `assert_eq!`, `assert_ne!` with descriptive messages.
   - `mockall` for trait-based mocking where applicable.
 - You MUST verify tests are independent (no execution order dependency) and clean up after themselves.
+- Integration tests live in `tests/*.rs` and use `MockAzureDevOpsApi`; they require `--features test-support` (included when running `make test`). Plans adding integration tests MUST enable this feature.
 - If ANY test is broken (even unrelated to the change): you MUST flag it.
 
 ### Linting Verification — MANDATORY
 
-- You MUST run `make lint`. You MUST flag ANY violation in output (even unrelated) with the exact output.
+- You MUST run `make lint` (runs `cargo clippy --features test-support`). You MUST flag ANY violation in output (even unrelated) with the exact output.
 - You MUST flag ANY linting suppression (`#[allow(...)]` attributes, rules disabled in `clippy.toml`) that is not justified by a documented design decision. Flag as CRITICAL.
 
 ---

.claude/agents/plan-reviewer.md

@@ -85,6 +85,7 @@ Review the ENTIRE plan across five dimensions: **Structure & Ordering**, **QA Ad
   - `assert!`, `assert_eq!`, `assert_ne!` with messages.
   - `mockall` for trait-based mocking where applicable.
 - You MUST verify: integration tests (when planned) use mock servers and test utilities (not real external services).
+- **test-support feature**: Integration tests in `tests/*.rs` use `MockAzureDevOpsApi`. That mock is generated only when `test-support` is enabled (because `cfg(test)` is not active for the library when built as a dep for integration tests). Plans MUST use `make test` / `cargo test --features test-support` and MUST NOT assume plain `cargo test` runs integration tests.
 
 ### Linting Suppression — CRITICAL
 

CLAUDE.md

@@ -214,8 +214,8 @@ This project uses specialized subagents (defined in `.claude/agents/`) to enforc
 - Build (debug): `make build` (runs `cargo build`)
 - Build (release): `make release` (runs `cargo build --release`)
 - Check compilation: `make check` (runs `cargo check`)
-- Run all tests: `make test` (runs `cargo test`)
-- Lint: `make lint` (runs `cargo clippy -- -D warnings`)
+- Run all tests: `make test` (runs `cargo test --features test-support`). The `test-support` feature enables `mockall` and integration tests; without it, `cargo test` skips integration tests because `MockAzureDevOpsApi` is not generated when the library is compiled as a dependency.
+- Lint: `make lint` (runs `cargo clippy --features test-support -- -D warnings`)
 - Format: `make fmt` (runs `cargo fmt`)
 - All quality gates: `make all` (runs `fmt` → `lint` → `test` → `build`)
 - Clean: `make clean` (runs `cargo clean`)
@@ -251,6 +251,7 @@ This project uses specialized subagents (defined in `.claude/agents/`) to enforc
 - `AzureDevOpsApi` is defined in `src/azure/api_trait.rs` with `#[cfg_attr(feature = "test-support", mockall::automock)]`.
 - `AzureDevOpsClient` implements the trait by delegating to the standalone API functions.
 - Integration tests use `MockAzureDevOpsApi` (enabled via `test-support` feature) to verify tool behavior without external services.
+- **Why `test-support` feature?** `cfg(test)` is not active when the library is built as a dependency for integration tests (`tests/*.rs`), so `#[cfg_attr(test, mockall::automock)]` would never generate `MockAzureDevOpsApi`. A Cargo feature ensures the mock is generated whenever tests are run. Always use `make test` or `cargo test --features test-support` to run the full suite.
 
 ### Dependency injection
 - Pass dependencies explicitly via constructor parameters (`new()`).

docs/PROJECT.md

@@ -49,7 +49,7 @@ Cargo workspace with two members:
 
 | Crate | Version | Purpose |
 |---|---|---|
-| `mockall` | 0.12 | Trait-based test mocking |
+| `mockall` | 0.12 (optional, via `test-support` feature) | Trait-based test mocking for `MockAzureDevOpsApi`; required for integration tests |
 
 ### Codegen Crate (`mcp-tools-codegen`)
 
@@ -106,8 +106,10 @@ MCP tool responses are optimized for LLM consumption:
 | `make build` | `cargo build` (debug) |
 | `make release` | `cargo build --release` |
 | `make check` | `cargo check` |
-| `make test` | `cargo test` |
-| `make lint` | `cargo clippy -- -D warnings` |
+| `make test` | `cargo test --features test-support` (unit + integration tests; see below) |
+| `make lint` | `cargo clippy --features test-support -- -D warnings` |
+
+**test-support feature**: `mockall` and integration tests require the `test-support` feature because `cfg(test)` is not active when the library is built as a dependency for `tests/*.rs`. Without `--features test-support`, `cargo test` skips integration tests. Always use `make test` for the full suite.
 | `make fmt` | `cargo fmt` |
 | `make clean` | `cargo clean` |
 | `make all` | `fmt` → `lint` → `test` → `build` |