Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Commit 3889290

Browse files
Use real generic syntax instead of comment-based. (#89)
Also update pubspec to support v2 dev SDKs.
1 parent 4721de8 commit 3889290

File tree

8 files changed

+157
-152
lines changed

8 files changed

+157
-152
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.7.5 - 2017-08-04
2+
3+
* Use real generic syntax instead of comment-based.
4+
* Support 2.0.0 dev SDKs.
5+
16
## 0.7.4 - 2017-07-07
27

38
* Added call options to gRPC client stubs.

lib/protobuf_field.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,24 +106,24 @@ class ProtobufField {
106106

107107
if (isRepeated) {
108108
if (baseType.isMessage || baseType.isGroup) {
109-
return '..pp/*<$type>*/($number, $quotedName, $typeConstant,'
109+
return '..pp<$type>($number, $quotedName, $typeConstant,'
110110
' $type.$checkItem, $type.create)';
111111
} else if (baseType.isEnum) {
112-
return '..pp/*<$type>*/($number, $quotedName, $typeConstant,'
112+
return '..pp<$type>($number, $quotedName, $typeConstant,'
113113
' $type.$checkItem, null, $type.valueOf)';
114114
} else {
115-
return '..p/*<$type>*/($number, $quotedName, $typeConstant)';
115+
return '..p<$type>($number, $quotedName, $typeConstant)';
116116
}
117117
}
118118

119119
String makeDefault = generateDefaultFunction(package);
120120
if (baseType.isEnum) {
121121
String valueOf = '$type.valueOf';
122-
return '..e/*<$type>*/('
122+
return '..e<$type>('
123123
'$number, $quotedName, $typeConstant, $makeDefault, $valueOf)';
124124
}
125125

126-
String prefix = '..a/*<$type>*/($number, $quotedName, $typeConstant';
126+
String prefix = '..a<$type>($number, $quotedName, $typeConstant';
127127
if (makeDefault == null) return prefix + ')';
128128

129129
if (baseType.isMessage || baseType.isGroup) {

lib/src/dart_options.pb.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/descriptor.pb.dart

Lines changed: 118 additions & 118 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/plugin.pb.dart

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: protoc_plugin
2-
version: 0.7.4
2+
version: 0.7.5
33
author: Dart Team <[email protected]>
44
description: Protoc compiler plugin to generate Dart code
55
homepage: https://github.com/dart-lang/dart-protoc-plugin
66
environment:
7-
sdk: '>=1.13.0 <2.0.0'
7+
sdk: '>=1.21.0 <2.0.0-dev.infinity'
88
dependencies:
99
fixnum: ^0.10.5
1010
path: ^1.0.0
11-
protobuf: ^0.5.4
11+
protobuf: ^0.5.5
1212
dart_style: ^1.0.6
1313
dev_dependencies:
1414
browser: any

test/file_generator_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ import 'package:protobuf/protobuf.dart';
8787
8888
class PhoneNumber extends GeneratedMessage {
8989
static final BuilderInfo _i = new BuilderInfo('PhoneNumber')
90-
..a/*<String>*/(1, 'number', PbFieldType.QS)
91-
..a/*<int>*/(2, 'type', PbFieldType.O3)
92-
..a/*<String>*/(3, 'name', PbFieldType.OS, '\$')
90+
..a<String>(1, 'number', PbFieldType.QS)
91+
..a<int>(2, 'type', PbFieldType.O3)
92+
..a<String>(3, 'name', PbFieldType.OS, '\$')
9393
;
9494
9595
PhoneNumber() : super();
@@ -693,9 +693,9 @@ import 'package2.pb.dart' as p2;
693693
694694
class M extends GeneratedMessage {
695695
static final BuilderInfo _i = new BuilderInfo('M')
696-
..a/*<M>*/(1, 'm', PbFieldType.OM, M.getDefault, M.create)
697-
..a/*<p1.M>*/(2, 'm1', PbFieldType.OM, p1.M.getDefault, p1.M.create)
698-
..a/*<p2.M>*/(3, 'm2', PbFieldType.OM, p2.M.getDefault, p2.M.create)
696+
..a<M>(1, 'm', PbFieldType.OM, M.getDefault, M.create)
697+
..a<p1.M>(2, 'm1', PbFieldType.OM, p1.M.getDefault, p1.M.create)
698+
..a<p2.M>(3, 'm2', PbFieldType.OM, p2.M.getDefault, p2.M.create)
699699
..hasRequiredFields = false
700700
;
701701

test/message_generator_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ class PhoneNumber_PhoneType extends ProtobufEnum {
4343
String expected = r'''
4444
class PhoneNumber extends GeneratedMessage {
4545
static final BuilderInfo _i = new BuilderInfo('PhoneNumber')
46-
..a/*<String>*/(1, 'number', PbFieldType.QS)
47-
..e/*<PhoneNumber_PhoneType>*/(2, 'type', PbFieldType.OE, PhoneNumber_PhoneType.MOBILE, PhoneNumber_PhoneType.valueOf)
48-
..a/*<String>*/(3, 'name', PbFieldType.OS, '\$')
46+
..a<String>(1, 'number', PbFieldType.QS)
47+
..e<PhoneNumber_PhoneType>(2, 'type', PbFieldType.OE, PhoneNumber_PhoneType.MOBILE, PhoneNumber_PhoneType.valueOf)
48+
..a<String>(3, 'name', PbFieldType.OS, '\$')
4949
;
5050
5151
PhoneNumber() : super();

0 commit comments

Comments
 (0)